| commit | 07ae3abf34f504e9766b7a34f9bc974ac4d13843 | [log] [tgz] |
|---|---|---|
| author | EconCode <56735547+EconCode@users.noreply.github.com> | Sat Oct 26 16:31:29 2019 +0200 |
| committer | EconCode <56735547+EconCode@users.noreply.github.com> | Sat Oct 26 16:31:29 2019 +0200 |
| tree | 111ccbae45d17de625a6bac8bd7686a232e2c571 | |
| parent | 09a6868ccde6e1a0824c9a7ee33b003bb260855a [diff] |
fix: unregistering url wrong formated string
Fixed the formated string for unregistering webhooks.
String should look like:
"/admin/api/2019-04/webhooks/#{webhook_id}.json"
Taken from shopify api documentation - deleting webhooks:
https://help.shopify.com/en/api/reference/events/webhook?api[version]=2019-04#destroy-2019-04
diff --git a/erpnext/erpnext_integrations/doctype/shopify_settings/shopify_settings.py b/erpnext/erpnext_integrations/doctype/shopify_settings/shopify_settings.py index a4332b1..46422f5 100644 --- a/erpnext/erpnext_integrations/doctype/shopify_settings/shopify_settings.py +++ b/erpnext/erpnext_integrations/doctype/shopify_settings/shopify_settings.py
@@ -50,7 +50,7 @@ deleted_webhooks = [] for d in self.webhooks: - url = get_shopify_url('admin/api/2019-04/webhooks.json'.format(d.webhook_id), self) + url = get_shopify_url('admin/api/2019-04/webhooks/{0}.json'.format(d.webhook_id), self) try: res = session.delete(url, headers=get_header(self)) res.raise_for_status()