fixes in item: organized code
diff --git a/stock/doctype/item/item.py b/stock/doctype/item/item.py
index a16296d..4767742 100644
--- a/stock/doctype/item/item.py
+++ b/stock/doctype/item/item.py
@@ -24,50 +24,169 @@
from webnotes.model.controller import DocListController
class DocType(DocListController):
- def get_tax_rate(self, tax_type):
- rate = webnotes.conn.sql("select tax_rate from tabAccount where name = %s", tax_type)
- ret = {
- 'tax_rate' : rate and flt(rate[0][0]) or 0
- }
- return ret
+ def validate(self):
+ if not self.doc.stock_uom:
+ msgprint(_("Please enter Default Unit of Measure"), raise_exception=1)
+
+ self.check_stock_uom_with_bin()
+ self.validate_conversion_factor()
+ self.add_default_uom_in_conversion_factor_table()
+ self.valiadte_item_type()
+ self.check_for_active_boms()
+ self.check_ref_rate_detail()
+ self.fill_customer_code()
+ self.check_item_tax()
+ self.validate_barcode()
+ self.check_non_asset_warehouse()
+ self.cant_change()
+ if self.doc.name:
+ self.old_page_name = webnotes.conn.get_value('Item', self.doc.name, 'page_name')
+
def on_update(self):
self.validate_name_with_item_group()
-
- # webpage updates
self.update_website()
-
+
+ def add_default_uom_in_conversion_factor_table(self):
+ uom_conv_list = [d.uom for d in self.doclist.get({"parentfield": "uom_conversion_details"})]
+ if self.doc.stock_uom not in uom_conv_list:
+ ch = addchild(self.doc, 'uom_conversion_details', 'UOM Conversion Detail', self.doclist)
+ ch.uom = self.doc.stock_uom
+ ch.conversion_factor = 1
+
+ def check_stock_uom_with_bin(self):
bin = webnotes.conn.sql("select stock_uom from `tabBin` where item_code = %s",
self.doc.item_code)
- if bin and cstr(bin[0][0]) and cstr(bin[0][0]) != cstr(self.doc.stock_uom):
- msgprint("Please Update Stock UOM with the help of Stock UOM Replace Utility.")
- raise Exception
+ if self.doc.stock_uom and bin and cstr(bin[0][0]) \
+ and cstr(bin[0][0]) != cstr(self.doc.stock_uom):
+ msgprint(_("Please Update Stock UOM with the help of Stock UOM Replace Utility."),
+ raise_exception=1)
+
+ def validate_conversion_factor(self):
check_list = []
for d in getlist(self.doclist,'uom_conversion_details'):
- if not self.doc.stock_uom:
- msgprint("Please enter Stock UOM first.")
- raise Exception
-
if cstr(d.uom) in check_list:
- msgprint("UOM %s has been entered more than once in Conversion Factor Details." % cstr(d.uom))
- raise Exception
+ msgprint(_("UOM %s has been entered more than once in Conversion Factor Table." %
+ cstr(d.uom)), raise_exception=1)
else:
check_list.append(cstr(d.uom))
- if cstr(d.uom) == cstr(self.doc.stock_uom):
- if flt(d.conversion_factor) != 1:
- msgprint("Conversion Factor of UOM : %s should be equal to 1. As UOM : %s is Stock UOM of Item: %s." % ( cstr(d.uom), cstr(d.uom), cstr(self.doc.name)))
- raise Exception
- elif cstr(d.uom) != cstr(self.doc.stock_uom) and flt(d.conversion_factor) == 1:
- msgprint("Conversion Factor of UOM : %s should not be equal to 1. As UOM : %s is not Stock UOM of Item: %s." % ( cstr(d.uom), cstr(d.uom), cstr(self.doc.name)))
- raise Exception
+ if d.uom and cstr(d.uom) == cstr(self.doc.stock_uom) and flt(d.conversion_factor) != 1:
+ msgprint(_("""Conversion Factor of UOM: %s should be equal to 1.
+ As UOM: %s is Stock UOM of Item: %s.""" %
+ (d.uom, d.uom, self.doc.name)), raise_exception=1)
+ elif d.uom and cstr(d.uom)!= self.doc.stock_uom and flt(d.conversion_factor) == 1:
+ msgprint(_("""Conversion Factor of UOM: %s should not be equal to 1.
+ As UOM: %s is not Stock UOM of Item: %s""" %
+ (d.uom, d.uom, self.doc.name)), raise_exception=1)
+
+ def valiadte_item_type(self):
+ if cstr(self.doc.is_manufactured_item) == "No":
+ self.doc.is_pro_applicable = "No"
- if not cstr(self.doc.stock_uom) in check_list :
- child = addchild( self.doc, 'uom_conversion_details',
- 'UOM Conversion Detail', self.doclist)
- child.uom = self.doc.stock_uom
- child.conversion_factor = 1
- child.save()
+ if self.doc.is_pro_applicable == 'Yes' and self.doc.is_stock_item == 'No':
+ msgprint("As Production Order can be made for this Item, then Is Stock Item Should be 'Yes' as we maintain it's stock. Refer Manufacturing and Inventory section.", raise_exception=1)
+
+ if self.doc.has_serial_no == 'Yes' and self.doc.is_stock_item == 'No':
+ msgprint("'Has Serial No' can not be 'Yes' for non-stock item", raise_exception=1)
+
+ def check_for_active_boms(self):
+ def _check_for_active_boms(field_label):
+ if field_label in ['Is Active', 'Is Purchase Item']:
+ bom_mat = webnotes.conn.sql("""select distinct t1.parent
+ from `tabBOM Item` t1, `tabBOM` t2 where t2.name = t1.parent
+ and t1.item_code =%s and ifnull(t1.bom_no, '') = '' and t2.is_active = 1
+ and t2.docstatus = 1 and t1.docstatus =1 """, self.doc.name)
+ if bom_mat and bom_mat[0][0]:
+ msgprint(_(field_label) + _(" should be 'Yes'. As Item: ") + self.doc.name +
+ _(" is present in one or many Active BOMs"), raise_exception=1)
+
+ if ((field_label == 'Allow Production Order'
+ and self.doc.is_sub_contracted_item != 'Yes')
+ or (field_label == 'Is Sub Contracted Item'
+ and self.doc.is_manufactured_item != 'Yes')):
+ bom = webnotes.conn.sql("""select name from `tabBOM` where item = %s
+ and is_active = 1""", (self.doc.name,))
+ if bom and bom[0][0]:
+ msgprint(_(field_label) + _(" should be 'Yes'. As Item: ") + self.doc.name +
+ _(" is present in one or many Active BOMs"), raise_exception=1)
+
+ if not cint(self.doc.fields.get("__islocal")):
+ fl = {'is_manufactured_item' :'Allow Bill of Materials',
+ 'is_sub_contracted_item':'Is Sub Contracted Item',
+ 'is_purchase_item' :'Is Purchase Item',
+ 'is_pro_applicable' :'Allow Production Order'}
+ for d in fl:
+ if cstr(self.doc.fields.get(d)) != 'Yes':
+ _check_for_active_boms(fl[d])
+
+ def check_ref_rate_detail(self):
+ check_list=[]
+ for d in getlist(self.doclist,'ref_rate_details'):
+ if [cstr(d.price_list_name), cstr(d.ref_currency),
+ cint(d.selling), cint(d.buying)] in check_list:
+ msgprint("Ref Rate is entered twice for Price List : '%s' and Currency : '%s'." %
+ (d.price_list_name,d.ref_currency), raise_exception=1)
+ else:
+ check_list.append([cstr(d.price_list_name),cstr(d.ref_currency)])
+
+ def fill_customer_code(self):
+ """ Append all the customer codes and insert into "customer_code" field of item table """
+ cust_code=[]
+ for d in getlist(self.doclist,'item_customer_details'):
+ cust_code.append(d.ref_code)
+ self.doc.customer_code=','.join(cust_code)
+
+ def check_item_tax(self):
+ """Check whether Tax Rate is not entered twice for same Tax Type"""
+ check_list=[]
+ for d in getlist(self.doclist,'item_tax'):
+ if d.tax_type:
+ account_type = webnotes.conn.get_value("Account", d.tax_type, "account_type")
+
+ if account_type not in ['Tax', 'Chargeable']:
+ msgprint("'%s' is not Tax / Chargeable Account" % d.tax_type, raise_exception=1)
+ else:
+ if d.tax_type in check_list:
+ msgprint("Rate is entered twice for: '%s'" % d.tax_type, raise_exception=1)
+ else:
+ check_list.append(d.tax_type)
+
+ def validate_barcode(self):
+ if self.doc.barcode:
+ duplicate = webnotes.conn.sql("select name from tabItem where barcode = %s and name != %s", (self.doc.barcode, self.doc.name))
+ if duplicate:
+ msgprint("Barcode: %s already used in item: %s" %
+ (self.doc.barcode, cstr(duplicate[0][0])), raise_exception = 1)
+
+ def check_non_asset_warehouse(self):
+ if self.doc.is_asset_item == "Yes":
+ existing_qty = webnotes.conn.sql("select t1.warehouse, t1.actual_qty from tabBin t1, tabWarehouse t2 where t1.item_code=%s and (t2.warehouse_type!='Fixed Asset' or t2.warehouse_type is null) and t1.warehouse=t2.name and t1.actual_qty > 0", self.doc.name)
+ for e in existing_qty:
+ msgprint("%s Units exist in Warehouse %s, which is not an Asset Warehouse." %
+ (e[1],e[0]))
+ if existing_qty:
+ self.doc.is_asset_item = 'No'
+ msgprint(_("""Please transfer the above quantities to an asset warehouse \
+ before changing this item to an asset item"""), raise_exception=1)
+
+ def cant_change(self):
+ if not self.doc.fields.get("__islocal"):
+ vals = webnotes.conn.get_value("Item", self.doc.name,
+ ["has_serial_no", "is_stock_item", "valuation_method"], as_dict=True)
+
+ if vals and ((self.doc.is_stock_item == "No" and vals.is_stock_item == "Yes") or
+ vals.has_serial_no != self.doc.has_serial_no or
+ vals.valuation_method != self.doc.valuation_method):
+ if self.check_if_sle_exists() == "exists":
+ webnotes.msgprint(_("As there are existing stock transactions for this \
+ item, you can not change the values of 'Has Serial No', \
+ 'Is Stock Item' and 'Valuation Method'"), raise_exception=1)
+
+ def check_if_sle_exists(self):
+ sle = webnotes.conn.sql("""select name from `tabStock Ledger Entry`
+ where item_code = %s and ifnull(is_cancelled, 'No') = 'No'""", self.doc.name)
+ return sle and 'exists' or 'not exists'
def validate_name_with_item_group(self):
if webnotes.conn.exists("Item Group", self.doc.name):
@@ -104,107 +223,17 @@
webnotes.conn.set(self.doc, "page_name", None)
- # On delete 1. Delete BIN (if none of the corrosponding transactions present, it gets deleted. if present, rolled back due to exception)
- def on_trash(self):
- webnotes.conn.sql("""delete from tabBin where item_code=%s""", self.doc.item_code)
- webnotes.conn.sql("""delete from `tabStock Ledger Entry`
- where item_code=%s and is_cancelled='Yes' """, self.doc.item_code)
-
- if self.doc.page_name:
- from webnotes.webutils import clear_cache
- clear_cache(self.doc.page_name)
-
- # Check whether Ref Rate is not entered twice for same Price List and Currency
- def check_ref_rate_detail(self):
- check_list=[]
- for d in getlist(self.doclist,'ref_rate_details'):
- if [cstr(d.price_list_name),cstr(d.ref_currency),cint(d.selling),cint(d.buying)] in check_list:
- msgprint("Ref Rate is entered twice for Price List : '%s' and Currency : '%s'." % (d.price_list_name,d.ref_currency))
- raise Exception
- else:
- check_list.append([cstr(d.price_list_name),cstr(d.ref_currency)])
+ def get_tax_rate(self, tax_type):
+ return { "tax_rate": webnotes.conn.get_value("Account", tax_type, "tax_rate") }
- # Append all the customer codes and insert into "customer_code" field of item table
- def fill_customer_code(self):
- cust_code=[]
- for d in getlist(self.doclist,'item_customer_details'):
- cust_code.append(d.ref_code)
- self.doc.customer_code=','.join(cust_code)
+ def prepare_template_args(self):
+ from website.helpers.product import get_parent_item_groups
+ self.parent_groups = get_parent_item_groups(self.doc.item_group) + [{"name":self.doc.name}]
+ self.doc.title = self.doc.item_name
- def check_item_tax(self):
- """Check whether Tax Rate is not entered twice for same Tax Type"""
- check_list=[]
- for d in getlist(self.doclist,'item_tax'):
- if d.tax_type:
- account_type = webnotes.conn.get_value("Account", d.tax_type, "account_type")
-
- if account_type not in ['Tax', 'Chargeable']:
- msgprint("'%s' is not Tax / Chargeable Account" % d.tax_type, raise_exception=1)
- else:
- if d.tax_type in check_list:
- msgprint("Rate is entered twice for: '%s'" % d.tax_type, raise_exception=1)
- else:
- check_list.append(d.tax_type)
-
- def check_for_active_boms(self, field_label):
- if field_label in ['Is Active', 'Is Purchase Item']:
- bom_mat = webnotes.conn.sql("select distinct t1.parent from `tabBOM Item` t1, `tabBOM` t2 where t1.item_code =%s and (t1.bom_no = '' or t1.bom_no is NULL) and t2.name = t1.parent and t2.is_active = 1 and t2.docstatus = 1 and t1.docstatus =1 ", self.doc.name)
- if bom_mat and bom_mat[0][0]:
- msgprint("%s should be 'Yes'. As Item %s is present in one or many Active BOMs." % (cstr(field_label), cstr(self.doc.name)))
- raise Exception
- if ((field_label == 'Allow Production Order'
- and self.doc.is_sub_contracted_item != 'Yes')
- or (field_label == 'Is Sub Contracted Item'
- and self.doc.is_manufactured_item != 'Yes')):
- bom = webnotes.conn.sql("select name from `tabBOM` where item = %s and is_active = 1",
- (self.doc.name,))
- if bom and bom[0][0]:
- msgprint("%s should be 'Yes'. As Item %s is present in one or many Active BOMs." % (cstr(field_label), cstr(self.doc.name)))
- raise Exception
-
- def validate_barcode(self):
- if self.doc.barcode:
- duplicate = webnotes.conn.sql("select name from tabItem where barcode = %s and name != %s", (self.doc.barcode, self.doc.name))
- if duplicate:
- msgprint("Barcode: %s already used in item: %s" % (self.doc.barcode, cstr(duplicate[0][0])), raise_exception = 1)
-
- def validate(self):
- if not cint(self.doc.fields.get("__islocal")):
- fl = {'is_manufactured_item' :'Allow Bill of Materials',
- 'is_sub_contracted_item':'Is Sub Contracted Item',
- 'is_purchase_item' :'Is Purchase Item',
- 'is_pro_applicable' :'Allow Production Order'}
- for d in fl:
- if cstr(self.doc.fields.get(d)) != 'Yes':
- self.check_for_active_boms(fl[d])
- self.check_ref_rate_detail()
- self.fill_customer_code()
- self.check_item_tax()
- self.validate_barcode()
- self.check_non_asset_warehouse()
- self.cant_change()
-
- if cstr(self.doc.is_manufactured_item) == "No":
- self.doc.is_pro_applicable = "No"
-
- if self.doc.is_pro_applicable == 'Yes' and self.doc.is_stock_item == 'No':
- msgprint("As Production Order can be made for this Item, then Is Stock Item Should be 'Yes' as we maintain it's stock. Refer Manufacturing and Inventory section.", raise_exception=1)
-
- if self.doc.has_serial_no == 'Yes' and self.doc.is_stock_item == 'No':
- msgprint("'Has Serial No' can not be 'Yes' for non-stock item", raise_exception=1)
-
- if self.doc.name:
- self.old_page_name = webnotes.conn.get_value('Item', self.doc.name, 'page_name')
-
- def check_non_asset_warehouse(self):
- if self.doc.is_asset_item == "Yes":
- existing_qty = webnotes.conn.sql("select t1.warehouse, t1.actual_qty from tabBin t1, tabWarehouse t2 where t1.item_code=%s and (t2.warehouse_type!='Fixed Asset' or t2.warehouse_type is null) and t1.warehouse=t2.name and t1.actual_qty > 0", self.doc.name)
- for e in existing_qty:
- msgprint("%s Units exist in Warehouse %s, which is not an Asset Warehouse." % (e[1],e[0]))
- if existing_qty:
- msgprint("Please transfer the above quantities to an asset warehouse before changing this item to an asset item.")
- self.doc.is_asset_item = 'No'
- raise Exception
+ if self.doc.slideshow:
+ from website.helpers.slideshow import get_slideshow
+ get_slideshow(self)
def get_file_details(self, arg = ''):
file = webnotes.conn.sql("select file_group, description from tabFile where name = %s", eval(arg)['file_name'], as_dict = 1)
@@ -215,35 +244,17 @@
}
return ret
+ def on_trash(self):
+ webnotes.conn.sql("""delete from tabBin where item_code=%s""", self.doc.item_code)
+ webnotes.conn.sql("""delete from `tabStock Ledger Entry`
+ where item_code=%s and is_cancelled='Yes' """, self.doc.item_code)
- def check_if_sle_exists(self):
- sle = webnotes.conn.sql("select name from `tabStock Ledger Entry` where item_code = %s and ifnull(is_cancelled, 'No') = 'No'", self.doc.name)
- return sle and 'exists' or 'not exists'
+ if self.doc.page_name:
+ from webnotes.webutils import clear_cache
+ clear_cache(self.doc.page_name)
def on_rename(self,newdn,olddn):
webnotes.conn.sql("update tabItem set item_code = %s where name = %s", (newdn, olddn))
if self.doc.page_name:
from webnotes.webutils import clear_cache
- clear_cache(self.doc.page_name)
-
- def prepare_template_args(self):
- from website.helpers.product import get_parent_item_groups
- self.parent_groups = get_parent_item_groups(self.doc.item_group) + [{"name":self.doc.name}]
- self.doc.title = self.doc.item_name
-
- if self.doc.slideshow:
- from website.helpers.slideshow import get_slideshow
- get_slideshow(self)
-
- def cant_change(self):
- if not self.doc.fields.get("__islocal"):
- vals = webnotes.conn.get_value("Item", self.doc.name,
- ["has_serial_no", "is_stock_item", "valuation_method"], as_dict=True)
-
- if vals and ((self.doc.is_stock_item == "No" and vals.is_stock_item == "Yes") or
- vals.has_serial_no != self.doc.has_serial_no or
- vals.valuation_method != self.doc.valuation_method):
- if self.check_if_sle_exists() == "exists":
- webnotes.msgprint(_("As there are existing stock transactions for this \
- item, you can not change the values of 'Has Serial No', \
- 'Is Stock Item' and 'Valuation Method'"), raise_exception=1)
+ clear_cache(self.doc.page_name)
\ No newline at end of file
diff --git a/stock/doctype/item/item.txt b/stock/doctype/item/item.txt
index 1bd4f4c..38b8bcc 100644
--- a/stock/doctype/item/item.txt
+++ b/stock/doctype/item/item.txt
@@ -2,7 +2,7 @@
{
"creation": "2013-03-28 15:56:38",
"docstatus": 0,
- "modified": "2013-04-23 11:39:22",
+ "modified": "2013-04-23 11:44:39",
"modified_by": "Administrator",
"owner": "Administrator"
},