fix: show Exit Questionnaire button only to the users with write access
- fix linter issues
diff --git a/erpnext/hr/doctype/exit_interview/exit_interview.js b/erpnext/hr/doctype/exit_interview/exit_interview.js
index 849e854..502af42 100644
--- a/erpnext/hr/doctype/exit_interview/exit_interview.js
+++ b/erpnext/hr/doctype/exit_interview/exit_interview.js
@@ -3,7 +3,7 @@
frappe.ui.form.on('Exit Interview', {
refresh: function(frm) {
- if (!frm.doc.__islocal && !frm.doc.questionnaire_email_sent) {
+ if (!frm.doc.__islocal && !frm.doc.questionnaire_email_sent && frappe.boot.user.can_write.includes('Exit Interview')) {
frm.add_custom_button(__('Send Exit Questionnaire'), function () {
frm.trigger('send_exit_questionnaire');
});
diff --git a/erpnext/hr/doctype/exit_interview/exit_interview.py b/erpnext/hr/doctype/exit_interview/exit_interview.py
index ba75100..e72c47e 100644
--- a/erpnext/hr/doctype/exit_interview/exit_interview.py
+++ b/erpnext/hr/doctype/exit_interview/exit_interview.py
@@ -28,9 +28,9 @@
'docstatus': ('!=', 2)
})
if doc:
- frappe.throw(_('Exit Interview {0} already scheduled for Employee: {1}').format(
+ frappe.throw(_('Exit Interview {0} already exists for Employee: {1}').format(
get_link_to_form('Exit Interview', doc), frappe.bold(self.employee)),
- title=_('Duplicate Document'))
+ frappe.DuplicateEntryError)
def set_employee_email(self):
employee = frappe.get_doc('Employee', self.employee)
diff --git a/erpnext/hr/doctype/exit_interview/test_exit_interview.py b/erpnext/hr/doctype/exit_interview/test_exit_interview.py
index daf3d66..3a6316c 100644
--- a/erpnext/hr/doctype/exit_interview/test_exit_interview.py
+++ b/erpnext/hr/doctype/exit_interview/test_exit_interview.py
@@ -4,5 +4,6 @@
# import frappe
import unittest
+
class TestExitInterview(unittest.TestCase):
pass
diff --git a/erpnext/hr/notification/exit_interview_scheduled/exit_interview_scheduled.py b/erpnext/hr/notification/exit_interview_scheduled/exit_interview_scheduled.py
index e1ada61..5f697c9 100644
--- a/erpnext/hr/notification/exit_interview_scheduled/exit_interview_scheduled.py
+++ b/erpnext/hr/notification/exit_interview_scheduled/exit_interview_scheduled.py
@@ -1,4 +1,5 @@
-import frappe
+# import frappe
+
def get_context(context):
# do your magic here
diff --git a/erpnext/hr/report/employee_exits/employee_exits.py b/erpnext/hr/report/employee_exits/employee_exits.py
index fd49543..9325229 100644
--- a/erpnext/hr/report/employee_exits/employee_exits.py
+++ b/erpnext/hr/report/employee_exits/employee_exits.py
@@ -91,8 +91,6 @@
]
def get_data(filters):
- data = []
-
employee = frappe.qb.DocType('Employee')
interview = frappe.qb.DocType('Exit Interview')
fnf = frappe.qb.DocType('Full and Final Statement')