commit 13109aef9df5feb0088d0b7fa902bd7720f7df95
author Nabin Hait <nabinhait@gmail.com> Mon Sep 03 12:17:57 2018 +0530
committer Nabin Hait <nabinhait@gmail.com> Mon Sep 03 12:18:17 2018 +0530
tree 38cb3f20cf5603935b236830e792c2513120f7e8
parent 39216607475bb24a706920c0043603d958f9482d

fix: validate only if service stop date

erpnext/accounts/doctype/sales_invoice/sales_invoice.py

diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
index a45b953..53d0fda 100644
--- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
+++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
@@ -546,11 +546,12 @@
 
 		for item in self.items:
 			if item.enable_deferred_revenue:
-				if date_diff(item.service_stop_date, item.service_start_date) < 0:
-					frappe.throw(_("Service Stop Date cannot be before Service Start Date"))
+				if item.service_stop_date:
+					if date_diff(item.service_stop_date, item.service_start_date) < 0:
+						frappe.throw(_("Service Stop Date cannot be before Service Start Date"))
 
-				if date_diff(item.service_stop_date, item.service_end_date) > 0:
-					frappe.throw(_("Service Stop Date cannot be after Service End Date"))
+					if date_diff(item.service_stop_date, item.service_end_date) > 0:
+						frappe.throw(_("Service Stop Date cannot be after Service End Date"))
 
 				if old_stop_dates and old_stop_dates[item.name] and item.service_stop_date!=old_stop_dates[item.name]:
 					frappe.throw(_("Cannot change Service Stop Date for item in row {0}".format(item.idx)))