| commit | 1587ce3bfb2c33f58a12a4aa85f5ebddae579836 | [log] [tgz] |
|---|---|---|
| author | ruthra kumar <ruthra@erpnext.com> | Thu May 18 12:38:31 2023 +0530 |
| committer | GitHub <noreply@github.com> | Thu May 18 12:38:31 2023 +0530 |
| tree | 6db721391f0e64382983d40e7595716d9ee884cc | |
| parent | 73bcd4451aac1b532503ee21771e94d0221a6940 [diff] | |
| parent | 132846bbd107a921dfbfde9240f368bea9382cf7 [diff] |
Merge pull request #35335 from ruthra-kumar/incorrect_tds_calcuation_if_supplier_has_different_category fix: tds incorrectly calculated for invoice that are below threshold
diff --git a/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py b/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py index ad3477e..1f2d980 100644 --- a/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py +++ b/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py
@@ -302,7 +302,7 @@ "docstatus": 1, } - if not tax_details.get("consider_party_ledger_amount") and doctype != "Sales Invoice": + if doctype != "Sales Invoice": filters.update( {"apply_tds": 1, "tax_withholding_category": tax_details.get("tax_withholding_category")} )
diff --git a/erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py b/erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py index 1e86cf5..bc4f670 100644 --- a/erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py +++ b/erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py
@@ -110,9 +110,9 @@ invoices.append(pi1) # Cumulative threshold is 30000 - # Threshold calculation should be on both the invoices - # TDS should be applied only on 1000 - self.assertEqual(pi1.taxes[0].tax_amount, 1000) + # Threshold calculation should be only on the Second invoice + # Second didn't breach, no TDS should be applied + self.assertEqual(pi1.taxes, []) for d in reversed(invoices): d.cancel()