commit 180ba1dfc923ec4a2de6ff0245bd8b166d9f1d71
author rohitwaghchaure <rohitw1991@gmail.com> Thu May 06 14:03:15 2021 +0530
committer GitHub <noreply@github.com> Thu May 06 14:03:15 2021 +0530
tree f233d3f9119f568a3c6849b8d0337868c17f5249
parent 8be414873b4a782f4dc67006a8fe4bc5bc63750f
parent 136eb30081b7b74d3b500acf6731696b4692da8e

Merge pull request #25590 from 18alantom/fix-use-get-serial-nos

fix: use get_serial_nos for splitting

erpnext/accounts/doctype/sales_invoice/sales_invoice.py

diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
index 4461f29..4de8773 100644
--- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
+++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
@@ -1111,7 +1111,7 @@
 			if not item.serial_no:
 				continue
 
-			for serial_no in item.serial_no.split("\n"):
+			for serial_no in get_serial_nos(item.serial_no):
 				if serial_no and frappe.db.get_value('Serial No', serial_no, 'item_code') == item.item_code:
 					frappe.db.set_value('Serial No', serial_no, 'sales_invoice', invoice)