commit 1daaf6be2ae4cf30f0b0eaae84ccf15f52277ff0
author Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Mon Mar 21 10:45:07 2022 +0530
committer GitHub <noreply@github.com> Mon Mar 21 10:45:07 2022 +0530
tree 0ff4ee94a867cfd65fc6808de6b5a906b670f4b4
parent 6dc7d6b0857cbf92edf3bdb33420b8256c980f78
parent 2ff67902833283e120237435be3d53f8da8df2c4

Merge pull request #30317 from deepeshgarg007/opening_gl_validation

fix: P&L account validation on cancellation

erpnext/accounts/doctype/gl_entry/gl_entry.py

diff --git a/erpnext/accounts/doctype/gl_entry/gl_entry.py b/erpnext/accounts/doctype/gl_entry/gl_entry.py
index 192099b..6f7a0b2 100644
--- a/erpnext/accounts/doctype/gl_entry/gl_entry.py
+++ b/erpnext/accounts/doctype/gl_entry/gl_entry.py
@@ -136,7 +136,7 @@
 
 	def check_pl_account(self):
 		if self.is_opening=='Yes' and \
-				frappe.db.get_value("Account", self.account, "report_type")=="Profit and Loss":
+				frappe.db.get_value("Account", self.account, "report_type")=="Profit and Loss" and not self.is_cancelled:
 			frappe.throw(_("{0} {1}: 'Profit and Loss' type account {2} not allowed in Opening Entry")
 				.format(self.voucher_type, self.voucher_no, self.account))