Merge pull request #20393 from rohitwaghchaure/unlink_reference_name_from_batch_on_cancel_of_stock_transactions_develop
fix: unlink references from batch on cancellation of stock transactions
diff --git a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
index 1a14a2a..d4676ff 100644
--- a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
+++ b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
@@ -866,6 +866,7 @@
# because updating ordered qty in bin depends upon updated ordered qty in PO
if self.update_stock == 1:
self.update_stock_ledger()
+ self.delete_auto_created_batches()
self.make_gl_entries_on_cancel()
self.update_project()
diff --git a/erpnext/controllers/stock_controller.py b/erpnext/controllers/stock_controller.py
index f344cb3..14ee23b 100644
--- a/erpnext/controllers/stock_controller.py
+++ b/erpnext/controllers/stock_controller.py
@@ -234,6 +234,17 @@
frappe.throw(_("{0} {1}: Cost Center is mandatory for Item {2}").format(
_(self.doctype), self.name, item.get("item_code")))
+ def delete_auto_created_batches(self):
+ for d in self.items:
+ if not d.batch_no: continue
+
+ d.batch_no = None
+ d.db_set("batch_no", None)
+
+ for data in frappe.get_all("Batch",
+ {'reference_name': self.name, 'reference_doctype': self.doctype}):
+ frappe.delete_doc("Batch", data.name)
+
def get_sl_entries(self, d, args):
sl_dict = frappe._dict({
"item_code": d.get("item_code", None),
diff --git a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.py b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.py
index 691f92f..09adb56 100644
--- a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.py
+++ b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.py
@@ -195,6 +195,7 @@
# because updating ordered qty in bin depends upon updated ordered qty in PO
self.update_stock_ledger()
self.make_gl_entries_on_cancel()
+ self.delete_auto_created_batches()
def get_current_stock(self):
for d in self.get('supplied_items'):
diff --git a/erpnext/stock/doctype/stock_entry/stock_entry.py b/erpnext/stock/doctype/stock_entry/stock_entry.py
index 3607626..5a5d8a1 100644
--- a/erpnext/stock/doctype/stock_entry/stock_entry.py
+++ b/erpnext/stock/doctype/stock_entry/stock_entry.py
@@ -110,6 +110,7 @@
self.update_cost_in_project()
self.update_transferred_qty()
self.update_quality_inspection()
+ self.delete_auto_created_batches()
def set_job_card_data(self):
if self.job_card and not self.work_order: