commit 24442af9aed8bd8dd74eb3be0156f2007a6525a5
author Himanshu Warekar <himanshuwarekar@yahoo.com> Fri May 03 17:56:21 2019 +0530
committer Nabin Hait <nabinhait@gmail.com> Sat May 04 22:35:52 2019 +0530
tree e865885148555c143989c5f349641276aec32c58
parent fbed6a12d5797a4e07db37cc38556a8b7e180114

fix: use list comprehension

erpnext/selling/doctype/customer/customer.py

diff --git a/erpnext/selling/doctype/customer/customer.py b/erpnext/selling/doctype/customer/customer.py
index fd3d260..365c2ed 100644
--- a/erpnext/selling/doctype/customer/customer.py
+++ b/erpnext/selling/doctype/customer/customer.py
@@ -61,11 +61,7 @@
 				self.loyalty_program_tier = customer.loyalty_program_tier
 
 		if self.sales_team:
-			allocated_percentage = 0
-			for percentage in self.sales_team:
-				allocated_percentage += percentage.allocated_percentage
-
-			if not allocated_percentage == 100:
+			if sum([member.allocated_percentage for member in self.sales_team]) != 100:
 				frappe.throw(_("Total contribution percentage should be equal to 100"))
 
 	def check_customer_group_change(self):