fix(test): e-commerce fetch logged-in user item price.
diff --git a/erpnext/e_commerce/doctype/website_item/test_website_item.py b/erpnext/e_commerce/doctype/website_item/test_website_item.py
index 6f64a59..b39e4df 100644
--- a/erpnext/e_commerce/doctype/website_item/test_website_item.py
+++ b/erpnext/e_commerce/doctype/website_item/test_website_item.py
@@ -47,15 +47,26 @@
]
})
elif self._testMethodName in WEBITEM_PRICE_TESTS:
- create_user_if_not_exists("test_contact_customer@example.com", "_Test Contact For _Test Customer")
+ create_user_and_customer_if_not_exists("test_contact_customer@example.com", "_Test Contact For _Test Customer")
create_regular_web_item()
make_web_item_price(item_code="Test Mobile Phone")
+
+ # Note: When testing web item pricing rule logged-in user pricing rule must differ from guest pricing rule or test will falsely pass.
+ # This is because make_web_pricing_rule creates a pricing rule "selling": 1, without specifying "applicable_for". Therefor,
+ # when testing for logged-in user the test will get the previous pricing rule because "selling" is still true.
+ #
+ # I've attempted to mitigate this by setting applicable_for=Customer, and customer=Guest however, this only results in PermissionError failing the test.
make_web_pricing_rule(
title="Test Pricing Rule for Test Mobile Phone",
item_code="Test Mobile Phone",
+ selling=1)
+ make_web_pricing_rule(
+ title="Test Pricing Rule for Test Mobile Phone (Customer)",
+ item_code="Test Mobile Phone",
selling=1,
+ discount_percentage="25",
applicable_for="Customer",
- customer="test_contact_customer@example.com")
+ customer="_Test Customer")
def test_index_creation(self):
"Check if index is getting created in db."
@@ -201,11 +212,11 @@
self.assertTrue(bool(data.product_info["price"]))
price_object = data.product_info["price"]
- self.assertEqual(price_object.get("discount_percent"), 10)
- self.assertEqual(price_object.get("price_list_rate"), 900)
+ self.assertEqual(price_object.get("discount_percent"), 25)
+ self.assertEqual(price_object.get("price_list_rate"), 750)
self.assertEqual(price_object.get("formatted_mrp"), "₹ 1,000.00")
- self.assertEqual(price_object.get("formatted_price"), "₹ 900.00")
- self.assertEqual(price_object.get("formatted_discount_percent"), "10%")
+ self.assertEqual(price_object.get("formatted_price"), "₹ 750.00")
+ self.assertEqual(price_object.get("formatted_discount_percent"), "25%")
# switch to admin and disable show price
frappe.set_user("Administrator")
@@ -494,7 +505,9 @@
"discount_percentage": kwargs.get("discount_percentage") or 10,
"company": kwargs.get("company") or "_Test Company",
"currency": kwargs.get("currency") or "INR",
- "for_price_list": kwargs.get("price_list") or "_Test Price List India"
+ "for_price_list": kwargs.get("price_list") or "_Test Price List India",
+ "applicable_for": kwargs.get("applicable_for") or "",
+ "customer": kwargs.get("customer") or "",
})
pricing_rule.insert()
else:
@@ -503,7 +516,7 @@
return pricing_rule
-def create_user_if_not_exists(email, first_name = None):
+def create_user_and_customer_if_not_exists(email, first_name = None):
if frappe.db.exists("User", email):
return
@@ -515,4 +528,11 @@
"first_name": first_name or email.split("@")[0]
}).insert(ignore_permissions=True)
+ contact = frappe.get_last_doc("Contact", filters={"email_id": email})
+ link = contact.append('links', {})
+ link.link_doctype = "Customer"
+ link.link_name = "_Test Customer"
+ link.link_title = "_Test Customer"
+ contact.save()
+
test_dependencies = ["Price List", "Item Price", "Customer", "Contact", "Item"]