fix: permissions for selling settings
diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py
index 4956f29..8896e29 100755
--- a/erpnext/selling/doctype/sales_order/sales_order.py
+++ b/erpnext/selling/doctype/sales_order/sales_order.py
@@ -754,6 +754,13 @@
@frappe.whitelist()
+def is_enable_cutoff_date_on_bulk_delivery_note_creation():
+ return frappe.db.get_single_value(
+ "Accounts Settings", "enable_cutoff_date_on_bulk_delivery_note_creation"
+ )
+
+
+@frappe.whitelist()
def close_or_unclose_sales_orders(names, status):
if not frappe.has_permission("Sales Order", "write"):
frappe.throw(_("Not permitted"), frappe.PermissionError)
diff --git a/erpnext/selling/doctype/sales_order/sales_order_list.js b/erpnext/selling/doctype/sales_order/sales_order_list.js
index 14ba051..6530175 100644
--- a/erpnext/selling/doctype/sales_order/sales_order_list.js
+++ b/erpnext/selling/doctype/sales_order/sales_order_list.js
@@ -68,10 +68,10 @@
});
listview.page.add_action_item(__("Delivery Note"), () => {
- frappe.db
- .get_single_value("Selling Settings", "enable_cutoff_date_on_bulk_delivery_note_creation")
- .then((value) => {
- if (value) {
+ frappe.call({
+ method: "erpnext.selling.doctype.sales_order.sales_order.is_enable_cutoff_date_on_bulk_delivery_note_creation",
+ callback: (r) => {
+ if (r.message) {
var dialog = new frappe.ui.Dialog({
title: __("Select Items up to Delivery Date"),
fields: [
@@ -98,7 +98,8 @@
} else {
erpnext.bulk_transaction_processing.create(listview, "Sales Order", "Delivery Note");
}
- });
+ },
+ });
});
listview.page.add_action_item(__("Advance Payment"), () => {