refactor(treewide): formatting and ruff fixes, + manually enabled F401
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
diff --git a/erpnext/accounts/party.py b/erpnext/accounts/party.py
index 4b3f0c8..85fe605 100644
--- a/erpnext/accounts/party.py
+++ b/erpnext/accounts/party.py
@@ -2,8 +2,6 @@
# License: GNU General Public License v3. See license.txt
-from typing import Optional
-
import frappe
from frappe import _, msgprint, qb, scrub
from frappe.contacts.doctype.address.address import get_company_address, get_default_address
@@ -69,7 +67,6 @@
shipping_address=None,
pos_profile=None,
):
-
if not party:
return {}
if not frappe.db.exists(party_type, party):
@@ -153,9 +150,7 @@
party_details["taxes_and_charges"] = tax_template
if cint(fetch_payment_terms_template):
- party_details["payment_terms_template"] = get_payment_terms_template(
- party.name, party_type, company
- )
+ party_details["payment_terms_template"] = get_payment_terms_template(party.name, party_type, company)
if not party_details.get("currency"):
party_details["currency"] = currency
@@ -173,9 +168,7 @@
# supplier tax withholding category
if party_type == "Supplier" and party:
- party_details["supplier_tds"] = frappe.get_value(
- party_type, party.name, "tax_withholding_category"
- )
+ party_details["supplier_tds"] = frappe.get_value(party_type, party.name, "tax_withholding_category")
if not party_details.get("tax_category") and pos_profile:
party_details["tax_category"] = frappe.get_value("POS Profile", pos_profile, "tax_category")
@@ -195,12 +188,8 @@
*,
ignore_permissions=False,
):
- billing_address_field = (
- "customer_address" if party_type == "Lead" else party_type.lower() + "_address"
- )
- party_details[billing_address_field] = party_address or get_default_address(
- party_type, party.name
- )
+ billing_address_field = "customer_address" if party_type == "Lead" else party_type.lower() + "_address"
+ party_details[billing_address_field] = party_address or get_default_address(party_type, party.name)
if doctype:
party_details.update(
get_fetch_values(doctype, billing_address_field, party_details[billing_address_field])
@@ -306,9 +295,7 @@
"department as contact_department",
]
- contact_details = frappe.db.get_value(
- "Contact", party_details.contact_person, fields, as_dict=True
- )
+ contact_details = frappe.db.get_value("Contact", party_details.contact_person, fields, as_dict=True)
party_details.update(contact_details)
@@ -328,9 +315,7 @@
party_details[f] = party.get(f)
# fields prepended with default in Customer doctype
- for f in ["currency"] + (
- ["sales_partner", "commission_rate"] if party_type == "Customer" else []
- ):
+ for f in ["currency"] + (["sales_partner", "commission_rate"] if party_type == "Customer" else []):
if party.get("default_" + f):
party_details[f] = party.get("default_" + f)
@@ -367,14 +352,10 @@
"Price List", price_list, "currency", cache=True
)
- party_details[
- "selling_price_list" if party.doctype == "Customer" else "buying_price_list"
- ] = price_list
+ party_details["selling_price_list" if party.doctype == "Customer" else "buying_price_list"] = price_list
-def set_account_and_due_date(
- party, account, party_type, company, posting_date, bill_date, doctype
-):
+def set_account_and_due_date(party, account, party_type, company, posting_date, bill_date, doctype):
if doctype not in ["POS Invoice", "Sales Invoice", "Purchase Invoice"]:
# not an invoice
return {party_type.lower(): party}
@@ -462,9 +443,7 @@
if not account:
account_name = (
- "default_advance_received_account"
- if party_type == "Customer"
- else "default_advance_paid_account"
+ "default_advance_received_account" if party_type == "Customer" else "default_advance_paid_account"
)
account = frappe.get_cached_value("Company", company, account_name)
@@ -473,9 +452,7 @@
@frappe.whitelist()
def get_party_bank_account(party_type, party):
- return frappe.db.get_value(
- "Bank Account", {"party_type": party_type, "party": party, "is_default": 1}
- )
+ return frappe.db.get_value("Bank Account", {"party_type": party_type, "party": party, "is_default": 1})
def get_party_account_currency(party_type, party, company):
@@ -567,9 +544,7 @@
"Company", frappe.db.get_default("Company"), "default_currency"
)
else:
- company_default_currency = frappe.get_cached_value(
- "Company", account.company, "default_currency"
- )
+ company_default_currency = frappe.get_cached_value("Company", account.company, "default_currency")
validate_party_gle_currency(doc.doctype, doc.name, account.company, party_account_currency)
@@ -600,9 +575,7 @@
template_name = get_payment_terms_template(party, party_type, company)
if template_name:
- due_date = get_due_date_from_template(template_name, posting_date, bill_date).strftime(
- "%Y-%m-%d"
- )
+ due_date = get_due_date_from_template(template_name, posting_date, bill_date).strftime("%Y-%m-%d")
else:
if party_type == "Supplier":
supplier_group = frappe.get_cached_value(party_type, party, "supplier_group")
@@ -761,7 +734,6 @@
def validate_party_frozen_disabled(party_type, party_name):
-
if frappe.flags.ignore_party_validation:
return
@@ -897,9 +869,7 @@
party_account_currency = get_party_account_currency(party_type, party, d.company)
if party_account_currency == company_default_currency:
- billing_this_year = flt(
- company_wise_billing_this_year.get(d.company, {}).get("base_grand_total")
- )
+ billing_this_year = flt(company_wise_billing_this_year.get(d.company, {}).get("base_grand_total"))
else:
billing_this_year = flt(company_wise_billing_this_year.get(d.company, {}).get("grand_total"))
@@ -925,7 +895,7 @@
return company_wise_info
-def get_party_shipping_address(doctype: str, name: str) -> Optional[str]:
+def get_party_shipping_address(doctype: str, name: str) -> str | None:
"""
Returns an Address name (best guess) for the given doctype and name for which `address_type == 'Shipping'` is true.
and/or `is_shipping_address = 1`.
@@ -991,7 +961,7 @@
return frappe._dict(data)
-def get_default_contact(doctype: str, name: str) -> Optional[str]:
+def get_default_contact(doctype: str, name: str) -> str | None:
"""
Returns contact name only if there is a primary contact for given doctype and name.