commit 40611e4f69ddeffcfe005ab3348fa0acb98cfeb6
author Faris Ansari <netchampfaris@users.noreply.github.com> Tue Oct 31 13:00:09 2017 +0530
committer Rushabh Mehta <rmehta@gmail.com> Tue Oct 31 13:00:09 2017 +0530
tree 4908bfb828cac5e0f9987052d4bfce141b13c570
parent dd0bdc7fa62e5a4efb742d81251ad7db012a2234

[fix] hub get_item_details (#11383)

erpnext/hub_node/__init__.py

diff --git a/erpnext/hub_node/__init__.py b/erpnext/hub_node/__init__.py
index 686fe8d..8efbed8 100644
--- a/erpnext/hub_node/__init__.py
+++ b/erpnext/hub_node/__init__.py
@@ -34,7 +34,9 @@
 	return response
 
 @frappe.whitelist()
-def get_item_details(hub_sync_id):
+def get_item_details(hub_sync_id=None):
+	if not hub_sync_id:
+		return
 	connection = get_connection()
 	return connection.get_doc('Hub Item', hub_sync_id)
 

erpnext/hub_node/page/hub/hub.js

diff --git a/erpnext/hub_node/page/hub/hub.js b/erpnext/hub_node/page/hub/hub.js
index 143f554..297a4d1 100644
--- a/erpnext/hub_node/page/hub/hub.js
+++ b/erpnext/hub_node/page/hub/hub.js
@@ -382,6 +382,7 @@
 			},
 			method: "erpnext.hub_node.get_item_details",
 			callback: (r) => {
+				if (!r || !r.message) return;
 				let item = r.message;
 				this.item_cache[item_code] = item;
 				this.render_item_page(item);