commit 40e35048b87234eb82409da09f164db30ec9bbd2
author Rohit Waghchaure <rohitw1991@gmail.com> Mon Jul 29 17:14:39 2019 +0530
committer Rohit Waghchaure <rohitw1991@gmail.com> Mon Jul 29 17:14:39 2019 +0530
tree c49e4b7745c1802a84862bef4363b036ced30c39
parent 06c7a7e6601914c36092c4cb1230f39701340ef2

fix: can't compare datetime.date to unicode

erpnext/selling/doctype/quotation/quotation.py

diff --git a/erpnext/selling/doctype/quotation/quotation.py b/erpnext/selling/doctype/quotation/quotation.py
index cc73e76..46009f4 100644
--- a/erpnext/selling/doctype/quotation/quotation.py
+++ b/erpnext/selling/doctype/quotation/quotation.py
@@ -34,7 +34,7 @@
 			self.with_items = 1
 
 	def validate_valid_till(self):
-		if self.valid_till and self.valid_till < self.transaction_date:
+		if self.valid_till and getdate(self.valid_till) < getdate(self.transaction_date):
 			frappe.throw(_("Valid till date cannot be before transaction date"))
 
 	def has_sales_order(self):