commit 434c2a1815f27c59de5cd94528bc371593bdd402
author PatrickDenis-stack <77415730+PatrickDenis-stack@users.noreply.github.com> Sat Nov 18 11:16:06 2023 +0100
committer PatrickDenis-stack <77415730+PatrickDenis-stack@users.noreply.github.com> Sat Nov 18 11:16:06 2023 +0100
tree 2dd2e31aa2bfdebb7348e8b5d8c3eafd25a277f1
parent a5a534164374be332518eaf34ac25beb1133ea96

fix: attributes were mandatory for manufacturers

erpnext/stock/doctype/item/item.json

diff --git a/erpnext/stock/doctype/item/item.json b/erpnext/stock/doctype/item/item.json
index c13d3eb..6e93f56 100644
--- a/erpnext/stock/doctype/item/item.json
+++ b/erpnext/stock/doctype/item/item.json
@@ -504,7 +504,7 @@
    "fieldtype": "Table",
    "hidden": 1,
    "label": "Variant Attributes",
-   "mandatory_depends_on": "has_variants",
+   "mandatory_depends_on": "eval:(doc.has_variants || doc.variant_of) && doc.variant_based_on==='Item Attribute'",
    "options": "Item Variant Attribute"
   },
   {