commit 43b80683ebd6a902fdb0ea0c4e11a8b2bee9841a
author ruthra kumar <ruthra@erpnext.com> Tue Oct 18 09:33:37 2022 +0530
committer ruthra kumar <ruthra@erpnext.com> Tue Oct 18 09:33:37 2022 +0530
tree 3e22cfd8bfe1703e1d7b44b28a5cc9ce0edb7f3c
parent d794b834fd4c6df89f1dd78d2822057dbdae48af

fix: party type and party mandatory on updating outstanding

erpnext/accounts/utils.py

diff --git a/erpnext/accounts/utils.py b/erpnext/accounts/utils.py
index 67574ca..ae4ab64 100644
--- a/erpnext/accounts/utils.py
+++ b/erpnext/accounts/utils.py
@@ -1467,7 +1467,12 @@
 
 	# on cancellation outstanding can be an empty list
 	voucher_outstanding = ple_query.get_voucher_outstandings(vouchers, common_filter=common_filter)
-	if voucher_type in ["Sales Invoice", "Purchase Invoice", "Fees"] and voucher_outstanding:
+	if (
+		voucher_type in ["Sales Invoice", "Purchase Invoice", "Fees"]
+		and party_type
+		and party
+		and voucher_outstanding
+	):
 		outstanding = voucher_outstanding[0]
 		ref_doc = frappe.get_doc(voucher_type, voucher_no)