fix: time to respond & resolve indicators
diff --git a/erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py b/erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py
index b5296fb..1cc5f38 100644
--- a/erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py
+++ b/erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py
@@ -12,7 +12,7 @@
).set(
doctype.agreement_status, 'First Response Due'
).where(
- (doctype.first_responded_on.isnull()) | (doctype.first_responded_on == '')
+ doctype.first_responded_on.isnull()
).run()
frappe.qb.update(
@@ -24,4 +24,4 @@
).run()
except Exception:
- frappe.log_error('Failed to Patch SLA Status')
\ No newline at end of file
+ frappe.log_error(title='Failed to Patch SLA Status')
\ No newline at end of file
diff --git a/erpnext/public/js/utils.js b/erpnext/public/js/utils.js
index f0facdd..2d8b1be 100755
--- a/erpnext/public/js/utils.js
+++ b/erpnext/public/js/utils.js
@@ -831,7 +831,7 @@
refresh: function(frm) {
if (frm.doc.status !== 'Closed' && frm.doc.service_level_agreement
- && frm.doc.agreement_status === 'Ongoing') {
+ && ['First Response Due', 'Resolution Due'].includes(frm.doc.agreement_status)) {
frappe.call({
'method': 'frappe.client.get',
args: {
@@ -884,8 +884,8 @@
function set_time_to_resolve_and_response(frm, apply_sla_for_resolution) {
frm.dashboard.clear_headline();
- let time_to_respond = get_status(frm.doc.response_by_variance);
- if (!frm.doc.first_responded_on && frm.doc.agreement_status === 'Ongoing') {
+ let time_to_respond = get_status(frm.doc.response_by);
+ if (!frm.doc.first_responded_on) {
time_to_respond = get_time_left(frm.doc.response_by, frm.doc.agreement_status);
}
@@ -899,8 +899,8 @@
if (apply_sla_for_resolution) {
- let time_to_resolve = get_status(frm.doc.resolution_by_variance);
- if (!frm.doc.resolution_date && frm.doc.agreement_status === 'Ongoing') {
+ let time_to_resolve = get_status(frm.doc.resolution_by);
+ if (!frm.doc.resolution_date) {
time_to_resolve = get_time_left(frm.doc.resolution_by, frm.doc.agreement_status);
}
@@ -924,8 +924,9 @@
return {'diff_display': diff_display, 'indicator': indicator};
}
-function get_status(variance) {
- if (variance > 0) {
+function get_status(timestamp) {
+ const time_left = moment(timestamp).diff(moment());
+ if (time_left >= 0) {
return {'diff_display': 'Fulfilled', 'indicator': 'green'};
} else {
return {'diff_display': 'Failed', 'indicator': 'red'};