commit 49dbbdc4cb2a7b8c385cca7b92684c7ab6c5e606
author Rohit Waghchaure <rohitw1991@gmail.com> Sat May 16 04:59:43 2020 +0530
committer Rohit Waghchaure <rohitw1991@gmail.com> Sat May 16 04:59:59 2020 +0530
tree e7b5fb7502f63f7e36c4eb3662f04712f32dec71
parent 0fbc96cc8c2c5ef4a437d1ede7bc8ccc70c18681

fix: promotional scheme not able to savce

erpnext/accounts/doctype/pricing_rule/pricing_rule.py

diff --git a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py
index 19f571f..4d9053a 100644
--- a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py
+++ b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py
@@ -99,7 +99,7 @@
 				self.same_item = 1
 
 	def validate_max_discount(self):
-		if self.rate_or_discount == "Discount Percentage" and self.items:
+		if self.rate_or_discount == "Discount Percentage" and self.get("items"):
 			for d in self.items:
 				max_discount = frappe.get_cached_value("Item", d.item_code, "max_discount")
 				if max_discount and flt(self.discount_percentage) > flt(max_discount):