commit 4cef0f59837d2161ac1c8309540e501b4b57a672
author Jannat Patel <31363128+pateljannat@users.noreply.github.com> Thu Feb 18 15:52:29 2021 +0530
committer Nabin Hait <nabinhait@gmail.com> Thu Feb 18 21:30:13 2021 +0530
tree e5565140bd6abff9707031fa0f31de3f2bb34992
parent d9c84dff0f8eff0c719a63e1a0cc01d3ea09fca2

fix: salary slip attribute error (#24455)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>

erpnext/payroll/doctype/salary_slip/salary_slip.py

diff --git a/erpnext/payroll/doctype/salary_slip/salary_slip.py b/erpnext/payroll/doctype/salary_slip/salary_slip.py
index 2d3bc57..60aff02 100644
--- a/erpnext/payroll/doctype/salary_slip/salary_slip.py
+++ b/erpnext/payroll/doctype/salary_slip/salary_slip.py
@@ -1103,10 +1103,10 @@
 			self.calculate_total_for_salary_slip_based_on_timesheet()
 		else:
 			self.total_deduction = 0.0
-			if self.earnings:
+			if hasattr(self, "earnings"):
 				for earning in self.earnings:
 					self.gross_pay += flt(earning.amount, earning.precision("amount"))
-			if self.deductions:
+			if hasattr(self, "deductions"):
 				for deduction in self.deductions:
 					self.total_deduction += flt(deduction.amount, deduction.precision("amount"))
 			self.net_pay = flt(self.gross_pay) - flt(self.total_deduction) - flt(self.total_loan_repayment)