commit 4f1a7e5aa8c12fc74e8090dd87e6e0c4213edefe
author Rushabh Mehta <rmehta@gmail.com> Mon May 11 15:22:43 2015 +0530
committer Rushabh Mehta <rmehta@gmail.com> Tue May 12 11:32:25 2015 +0530
tree 584ee03ee6d20584858568123e26c6000312a7ff
parent ec361ea6480f254978540e51aafa6c354bc40058

[fix] newsletter list duplicate

erpnext/crm/doctype/newsletter_list/newsletter_list.py

diff --git a/erpnext/crm/doctype/newsletter_list/newsletter_list.py b/erpnext/crm/doctype/newsletter_list/newsletter_list.py
index 4f89c9a..ba0eec7 100644
--- a/erpnext/crm/doctype/newsletter_list/newsletter_list.py
+++ b/erpnext/crm/doctype/newsletter_list/newsletter_list.py
@@ -68,7 +68,8 @@
 		validate_email_add(email, True)
 
 		if email:
-			try:
+			if not frappe.db.get_value("Newsletter List Subscriber",
+				{"newsletter_list": name, "email": email}):
 				frappe.get_doc({
 					"doctype": "Newsletter List Subscriber",
 					"newsletter_list": name,
@@ -76,10 +77,8 @@
 				}).insert()
 
 				count += 1
-			except Exception, e:
-				# ignore duplicate
-				if e.args[0] != 1062:
-					raise
+			else:
+				pass
 
 	frappe.msgprint(_("{0} subscribers added").format(count))