validate pricing rule discount with item max discount
diff --git a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py
index 5cf500a..c86e3f6 100644
--- a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py
+++ b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py
@@ -19,6 +19,7 @@
self.validate_min_max_qty()
self.cleanup_fields_value()
self.validate_price_or_discount()
+ self.validate_max_discount()
def validate_mandatory(self):
for field in ["apply_on", "applicable_for"]:
@@ -61,6 +62,13 @@
if flt(self.get(frappe.scrub(field))) < 0:
throw(_("{0} can not be negative").format(field))
+ def validate_max_discount(self):
+ if self.price_or_discount == "Discount Percentage" and self.item_code:
+ max_discount = frappe.db.get_value("Item", self.item_code, "max_discount")
+ if flt(self.discount_percentage) > max_discount:
+ throw(_("Max discount allowed for item: {0} is {1}%".format(self.item_code, max_discount)))
+
+
#--------------------------------------------------------------------------------
@frappe.whitelist()