fix: check child rows before update
diff --git a/erpnext/controllers/accounts_controller.py b/erpnext/controllers/accounts_controller.py
index 8d763ac..3babd67 100644
--- a/erpnext/controllers/accounts_controller.py
+++ b/erpnext/controllers/accounts_controller.py
@@ -3251,17 +3251,14 @@
def check_if_child_table_updated(
child_table_before_update, child_table_after_update, fields_to_check
):
- accounting_dimensions = get_accounting_dimensions() + ["cost_center", "project"]
+ fields_to_check = list(fields_to_check) + get_accounting_dimensions() + ["cost_center", "project"]
+
# Check if any field affecting accounting entry is altered
- for index, item in enumerate(child_table_after_update):
+ for index, item in enumerate(child_table_before_update):
for field in fields_to_check:
if child_table_before_update[index].get(field) != item.get(field):
return True
- for dimension in accounting_dimensions:
- if child_table_before_update[index].get(dimension) != item.get(dimension):
- return True
-
return False