fix(minor): update frappe.error_log to new API (#30864)
* fix(minor): update frappe.error_log to new API
* refactor: changes for updated log_error api
Co-authored-by: Ankush Menat <ankush@frappe.io>
diff --git a/erpnext/accounts/deferred_revenue.py b/erpnext/accounts/deferred_revenue.py
index a8776fa..f319003 100644
--- a/erpnext/accounts/deferred_revenue.py
+++ b/erpnext/accounts/deferred_revenue.py
@@ -539,19 +539,11 @@
frappe.db.commit()
except Exception as e:
if frappe.flags.in_test:
- traceback = frappe.get_traceback()
- frappe.log_error(
- title=_("Error while processing deferred accounting for Invoice {0}").format(doc.name),
- message=traceback,
- )
+ doc.log_error(f"Error while processing deferred accounting for Invoice {doc.name}")
raise e
else:
frappe.db.rollback()
- traceback = frappe.get_traceback()
- frappe.log_error(
- title=_("Error while processing deferred accounting for Invoice {0}").format(doc.name),
- message=traceback,
- )
+ doc.log_error(f"Error while processing deferred accounting for Invoice {doc.name}")
frappe.flags.deferred_accounting_error = True
@@ -632,12 +624,7 @@
frappe.db.commit()
except Exception:
frappe.db.rollback()
- traceback = frappe.get_traceback()
- frappe.log_error(
- title=_("Error while processing deferred accounting for Invoice {0}").format(doc.name),
- message=traceback,
- )
-
+ doc.log_error(f"Error while processing deferred accounting for Invoice {doc.name}")
frappe.flags.deferred_accounting_error = True
diff --git a/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.py b/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.py
index 3540f0b..3f5c064 100644
--- a/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.py
+++ b/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.py
@@ -136,7 +136,7 @@
except Exception:
frappe.db.rollback()
data_import.db_set("status", "Error")
- frappe.log_error(title=data_import.name)
+ data_import.log_error("Bank Statement Import failed")
finally:
frappe.flags.in_import = False
diff --git a/erpnext/accounts/doctype/bank_transaction/bank_transaction_upload.py b/erpnext/accounts/doctype/bank_transaction/bank_transaction_upload.py
index 9f2731d..372c53d 100644
--- a/erpnext/accounts/doctype/bank_transaction/bank_transaction_upload.py
+++ b/erpnext/accounts/doctype/bank_transaction/bank_transaction_upload.py
@@ -56,7 +56,7 @@
bank_transaction.submit()
success += 1
except Exception:
- frappe.log_error(frappe.get_traceback())
+ bank_transaction.log_error("Bank entry creation failed")
errors += 1
return {"success": success, "errors": errors}
diff --git a/erpnext/accounts/doctype/ledger_merge/ledger_merge.py b/erpnext/accounts/doctype/ledger_merge/ledger_merge.py
index c1e2975..18e5a1a 100644
--- a/erpnext/accounts/doctype/ledger_merge/ledger_merge.py
+++ b/erpnext/accounts/doctype/ledger_merge/ledger_merge.py
@@ -62,7 +62,7 @@
)
except Exception:
frappe.db.rollback()
- frappe.log_error(title=ledger_merge.name)
+ ledger_merge.log_error("Ledger merge failed")
finally:
if successful_merges == total:
ledger_merge.db_set("status", "Success")
diff --git a/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py b/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py
index 2d9ae93..9937742 100644
--- a/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py
+++ b/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py
@@ -2,9 +2,6 @@
# For license information, please see license.txt
-import traceback
-from json import dumps
-
import frappe
from frappe import _, scrub
from frappe.model.document import Document
@@ -247,11 +244,7 @@
except Exception:
errors += 1
frappe.db.rollback()
- message = "\n".join(
- ["Data:", dumps(d, default=str, indent=4), "--" * 50, "\nException:", traceback.format_exc()]
- )
- frappe.log_error(title="Error while creating Opening Invoice", message=message)
- frappe.db.commit()
+ doc.log_error("Opening invoice creation failed")
if errors:
frappe.msgprint(
_("You had {} errors while creating opening invoices. Check {} for more details").format(
diff --git a/erpnext/accounts/doctype/subscription/subscription.py b/erpnext/accounts/doctype/subscription/subscription.py
index f6dd86a..2243b19 100644
--- a/erpnext/accounts/doctype/subscription/subscription.py
+++ b/erpnext/accounts/doctype/subscription/subscription.py
@@ -722,9 +722,7 @@
frappe.db.commit()
except frappe.ValidationError:
frappe.db.rollback()
- frappe.db.begin()
- frappe.log_error(frappe.get_traceback())
- frappe.db.commit()
+ subscription.log_error("Subscription failed")
@frappe.whitelist()
diff --git a/erpnext/crm/doctype/linkedin_settings/linkedin_settings.py b/erpnext/crm/doctype/linkedin_settings/linkedin_settings.py
index b4657a2..64b3a01 100644
--- a/erpnext/crm/doctype/linkedin_settings/linkedin_settings.py
+++ b/erpnext/crm/doctype/linkedin_settings/linkedin_settings.py
@@ -72,7 +72,7 @@
if media_id:
return self.post_text(text, title, media_id=media_id)
else:
- frappe.log_error("Failed to upload media.", "LinkedIn Upload Error")
+ self.log_error("LinkedIn: Failed to upload media")
def upload_image(self, media):
media = get_file_path(media)
diff --git a/erpnext/crm/doctype/social_media_post/social_media_post.py b/erpnext/crm/doctype/social_media_post/social_media_post.py
index 2fd003e..55db29a 100644
--- a/erpnext/crm/doctype/social_media_post/social_media_post.py
+++ b/erpnext/crm/doctype/social_media_post/social_media_post.py
@@ -70,8 +70,7 @@
except Exception:
self.db_set("post_status", "Error")
- title = _("Error while POSTING {0}").format(self.name)
- frappe.log_error(message=frappe.get_traceback(), title=title)
+ self.log_error("Social posting failed")
def process_scheduled_social_media_posts():
diff --git a/erpnext/e_commerce/api.py b/erpnext/e_commerce/api.py
index 179829c..bfada0f 100644
--- a/erpnext/e_commerce/api.py
+++ b/erpnext/e_commerce/api.py
@@ -56,8 +56,7 @@
attribute_filters, field_filters, search_term=search, start=start, item_group=item_group
)
except Exception:
- traceback = frappe.get_traceback()
- frappe.log_error(traceback, frappe._("Product Engine Error"))
+ frappe.log_error("Product query with filter failed")
return {"exc": "Something went wrong!"}
# discount filter data
diff --git a/erpnext/e_commerce/redisearch_utils.py b/erpnext/e_commerce/redisearch_utils.py
index f2dd796..61b4b9e 100644
--- a/erpnext/e_commerce/redisearch_utils.py
+++ b/erpnext/e_commerce/redisearch_utils.py
@@ -245,8 +245,7 @@
def raise_redisearch_error():
"Create an Error Log and raise error."
- traceback = frappe.get_traceback()
- log = frappe.log_error(traceback, frappe._("Redisearch Error"))
+ log = frappe.log_error("Redisearch Error")
log_link = frappe.utils.get_link_to_form("Error Log", log.name)
frappe.throw(
diff --git a/erpnext/erpnext_integrations/connectors/woocommerce_connection.py b/erpnext/erpnext_integrations/connectors/woocommerce_connection.py
index 46a4d3c..6d977e0 100644
--- a/erpnext/erpnext_integrations/connectors/woocommerce_connection.py
+++ b/erpnext/erpnext_integrations/connectors/woocommerce_connection.py
@@ -32,7 +32,7 @@
error_message = (
frappe.get_traceback() + "\n\n Request Data: \n" + json.loads(frappe.request.data).__str__()
)
- frappe.log_error(error_message, "WooCommerce Error")
+ frappe.log_error("WooCommerce Error", error_message)
raise
diff --git a/erpnext/erpnext_integrations/doctype/gocardless_settings/gocardless_settings.py b/erpnext/erpnext_integrations/doctype/gocardless_settings/gocardless_settings.py
index e1972ae..55517e4 100644
--- a/erpnext/erpnext_integrations/doctype/gocardless_settings/gocardless_settings.py
+++ b/erpnext/erpnext_integrations/doctype/gocardless_settings/gocardless_settings.py
@@ -107,7 +107,7 @@
return self.create_charge_on_gocardless()
except Exception:
- frappe.log_error(frappe.get_traceback())
+ frappe.log_error("Gocardless payment reqeust failed")
return {
"redirect_to": frappe.redirect_to_message(
_("Server Error"),
@@ -163,21 +163,15 @@
or payment.status == "charged_back"
):
self.integration_request.db_set("status", "Cancelled", update_modified=False)
- frappe.log_error(
- _("Payment Cancelled. Please check your GoCardless Account for more details"),
- "GoCardless Payment Error",
- )
+ frappe.log_error("Gocardless payment cancelled")
self.integration_request.db_set("error", payment.status, update_modified=False)
else:
self.integration_request.db_set("status", "Failed", update_modified=False)
- frappe.log_error(
- _("Payment Failed. Please check your GoCardless Account for more details"),
- "GoCardless Payment Error",
- )
+ frappe.log_error("Gocardless payment failed")
self.integration_request.db_set("error", payment.status, update_modified=False)
except Exception as e:
- frappe.log_error(e, "GoCardless Payment Error")
+ frappe.log_error("GoCardless Payment Error")
if self.flags.status_changed_to == "Completed":
status = "Completed"
@@ -188,7 +182,7 @@
self.data.get("reference_doctype"), self.data.get("reference_docname")
).run_method("on_payment_authorized", self.flags.status_changed_to)
except Exception:
- frappe.log_error(frappe.get_traceback())
+ frappe.log_error("Gocardless redirect failed")
if custom_redirect_to:
redirect_to = custom_redirect_to
diff --git a/erpnext/erpnext_integrations/doctype/mpesa_settings/mpesa_settings.py b/erpnext/erpnext_integrations/doctype/mpesa_settings/mpesa_settings.py
index 78a598c..e389980 100644
--- a/erpnext/erpnext_integrations/doctype/mpesa_settings/mpesa_settings.py
+++ b/erpnext/erpnext_integrations/doctype/mpesa_settings/mpesa_settings.py
@@ -152,7 +152,7 @@
return response
except Exception:
- frappe.log_error(title=_("Mpesa Express Transaction Error"))
+ frappe.log_error("Mpesa Express Transaction Error")
frappe.throw(
_("Issue detected with Mpesa configuration, check the error logs for more details"),
title=_("Mpesa Express Error"),
@@ -203,7 +203,7 @@
integration_request.handle_success(transaction_response)
except Exception:
integration_request.handle_failure(transaction_response)
- frappe.log_error(frappe.get_traceback())
+ frappe.log_error("Mpesa: Failed to verify transaction")
else:
integration_request.handle_failure(transaction_response)
@@ -275,7 +275,7 @@
)
return response
except Exception:
- frappe.log_error(title=_("Account Balance Processing Error"))
+ frappe.log_error("Mpesa: Failed to get account balance")
frappe.throw(_("Please check your configuration and try again"), title=_("Error"))
@@ -315,7 +315,7 @@
except Exception:
request.handle_failure(account_balance_response)
frappe.log_error(
- title=_("Mpesa Account Balance Processing Error"), message=account_balance_response
+ title="Mpesa Account Balance Processing Error", message=account_balance_response
)
else:
request.handle_failure(account_balance_response)
diff --git a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_connector.py b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_connector.py
index 625dd31..38d6993 100644
--- a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_connector.py
+++ b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_connector.py
@@ -23,7 +23,7 @@
def get_access_token(self, public_token):
if public_token is None:
- frappe.log_error(_("Public token is missing for this bank"), _("Plaid public token error"))
+ frappe.log_error("Plaid: Public token is missing")
response = self.client.Item.public_token.exchange(public_token)
access_token = response["access_token"]
return access_token
@@ -61,10 +61,10 @@
try:
response = self.client.LinkToken.create(token_request)
except InvalidRequestError:
- frappe.log_error(frappe.get_traceback(), _("Plaid invalid request error"))
+ frappe.log_error("Plaid: Invalid request error")
frappe.msgprint(_("Please check your Plaid client ID and secret values"))
except APIError as e:
- frappe.log_error(frappe.get_traceback(), _("Plaid authentication error"))
+ frappe.log_error("Plaid: Authentication error")
frappe.throw(_(str(e)), title=_("Authentication Failed"))
else:
return response["link_token"]
@@ -81,7 +81,7 @@
except requests.Timeout:
pass
except Exception as e:
- frappe.log_error(frappe.get_traceback(), _("Plaid authentication error"))
+ frappe.log_error("Plaid: Authentication error")
frappe.throw(_(str(e)), title=_("Authentication Failed"))
def get_transactions(self, start_date, end_date, account_id=None):
@@ -102,4 +102,4 @@
except ItemError as e:
raise e
except Exception:
- frappe.log_error(frappe.get_traceback(), _("Plaid transactions sync error"))
+ frappe.log_error("Plaid: Transactions sync error")
diff --git a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py
index ce65f6c..62ea85f 100644
--- a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py
+++ b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py
@@ -54,7 +54,7 @@
)
bank.insert()
except Exception:
- frappe.log_error(frappe.get_traceback(), title=_("Plaid Link Error"))
+ frappe.log_error("Plaid Link Error")
else:
bank = frappe.get_doc("Bank", response["institution"]["name"])
bank.plaid_access_token = access_token
@@ -113,7 +113,7 @@
_("Bank account {0} already exists and could not be created again").format(account["name"])
)
except Exception:
- frappe.log_error(frappe.get_traceback(), title=_("Plaid Link Error"))
+ frappe.log_error("Plaid Link Error")
frappe.throw(
_("There was an error creating Bank Account while linking with Plaid."),
title=_("Plaid Link Failed"),
@@ -135,7 +135,7 @@
existing_account.save()
result.append(existing_bank_account)
except Exception:
- frappe.log_error(frappe.get_traceback(), title=_("Plaid Link Error"))
+ frappe.log_error("Plaid Link Error")
frappe.throw(
_("There was an error updating Bank Account {} while linking with Plaid.").format(
existing_bank_account
diff --git a/erpnext/erpnext_integrations/exotel_integration.py b/erpnext/erpnext_integrations/exotel_integration.py
index 522de9e..fd9f74e 100644
--- a/erpnext/erpnext_integrations/exotel_integration.py
+++ b/erpnext/erpnext_integrations/exotel_integration.py
@@ -1,6 +1,5 @@
import frappe
import requests
-from frappe import _
# api/method/erpnext.erpnext_integrations.exotel_integration.handle_incoming_call
# api/method/erpnext.erpnext_integrations.exotel_integration.handle_end_call
@@ -26,8 +25,7 @@
update_call_log(call_payload, call_log=call_log)
except Exception as e:
frappe.db.rollback()
- frappe.log_error(title=_("Error in Exotel incoming call"))
- frappe.db.commit()
+ exotel_settings.log_error("Error in Exotel incoming call")
@frappe.whitelist(allow_guest=True)
diff --git a/erpnext/erpnext_integrations/stripe_integration.py b/erpnext/erpnext_integrations/stripe_integration.py
index b12adc1..2d7e8a5 100644
--- a/erpnext/erpnext_integrations/stripe_integration.py
+++ b/erpnext/erpnext_integrations/stripe_integration.py
@@ -22,7 +22,7 @@
return create_subscription_on_stripe(stripe_settings)
except Exception:
- frappe.log_error(frappe.get_traceback())
+ stripe_settings.log_error("Unable to create Stripe subscription")
return {
"redirect_to": frappe.redirect_to_message(
_("Server Error"),
@@ -55,9 +55,9 @@
else:
stripe_settings.integration_request.db_set("status", "Failed", update_modified=False)
- frappe.log_error("Subscription N°: " + subscription.id, "Stripe Payment not completed")
+ frappe.log_error(f"Stripe Subscription ID {subscription.id}: Payment failed")
except Exception:
stripe_settings.integration_request.db_set("status", "Failed", update_modified=False)
- frappe.log_error(frappe.get_traceback())
+ stripe_settings.log_error("Unable to create Stripe subscription")
return stripe_settings.finalize_request()
diff --git a/erpnext/manufacturing/doctype/bom_update_log/bom_update_log.py b/erpnext/manufacturing/doctype/bom_update_log/bom_update_log.py
index 139dcbc..c0770fa 100644
--- a/erpnext/manufacturing/doctype/bom_update_log/bom_update_log.py
+++ b/erpnext/manufacturing/doctype/bom_update_log/bom_update_log.py
@@ -154,7 +154,7 @@
except Exception:
frappe.db.rollback()
- error_log = frappe.log_error(message=frappe.get_traceback(), title=_("BOM Update Tool Error"))
+ error_log = doc.log_error("BOM Update Tool Error")
doc.db_set("status", "Failed")
doc.db_set("error_log", error_log.name)
diff --git a/erpnext/patches/v12_0/move_bank_account_swift_number_to_bank.py b/erpnext/patches/v12_0/move_bank_account_swift_number_to_bank.py
index c069c24..671dfd1 100644
--- a/erpnext/patches/v12_0/move_bank_account_swift_number_to_bank.py
+++ b/erpnext/patches/v12_0/move_bank_account_swift_number_to_bank.py
@@ -17,7 +17,7 @@
"""
)
except Exception as e:
- frappe.log_error(e, title="Patch Migration Failed")
+ frappe.log_error("Bank to Bank Account patch migration failed")
frappe.reload_doc("accounts", "doctype", "bank_account")
frappe.reload_doc("accounts", "doctype", "payment_request")
diff --git a/erpnext/patches/v13_0/add_missing_fg_item_for_stock_entry.py b/erpnext/patches/v13_0/add_missing_fg_item_for_stock_entry.py
index 517a14a..ddbb7fd 100644
--- a/erpnext/patches/v13_0/add_missing_fg_item_for_stock_entry.py
+++ b/erpnext/patches/v13_0/add_missing_fg_item_for_stock_entry.py
@@ -96,8 +96,7 @@
make_sl_entries(sl_entries, True)
except Exception:
print(f"SLE entries not posted for the stock entry {doc.name}")
- traceback = frappe.get_traceback()
- frappe.log_error(traceback)
+ doc.log_error("Stock respost failed")
def get_sle_for_target_warehouse(doc, sl_entries, finished_item_row):
diff --git a/erpnext/patches/v13_0/convert_to_website_item_in_item_card_group_template.py b/erpnext/patches/v13_0/convert_to_website_item_in_item_card_group_template.py
index 020521d..1bac0fd 100644
--- a/erpnext/patches/v13_0/convert_to_website_item_in_item_card_group_template.py
+++ b/erpnext/patches/v13_0/convert_to_website_item_in_item_card_group_template.py
@@ -56,8 +56,5 @@
web_item = make_website_item(doc) # returns [website_item.name, item_name]
return web_item[0]
except Exception:
- title = f"{item}: Error while converting to Website Item "
- frappe.log_error(
- title + "for Item Card Group Template" + "\n\n" + frappe.get_traceback(), title=title
- )
+ doc.log_error("Website Item creation failed")
return None
diff --git a/erpnext/patches/v13_0/modify_invalid_gain_loss_gl_entries.py b/erpnext/patches/v13_0/modify_invalid_gain_loss_gl_entries.py
index 492e040..6c64ef6 100644
--- a/erpnext/patches/v13_0/modify_invalid_gain_loss_gl_entries.py
+++ b/erpnext/patches/v13_0/modify_invalid_gain_loss_gl_entries.py
@@ -40,7 +40,10 @@
)
if purchase_invoices + sales_invoices:
- frappe.log_error(json.dumps(purchase_invoices + sales_invoices, indent=2), title="Patch Log")
+ frappe.log_error(
+ "Fix invalid gain / loss patch log",
+ message=json.dumps(purchase_invoices + sales_invoices, indent=2),
+ )
acc_frozen_upto = frappe.db.get_value("Accounts Settings", None, "acc_frozen_upto")
if acc_frozen_upto:
diff --git a/erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py b/erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py
index 2eb6bec..8ea96ab 100644
--- a/erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py
+++ b/erpnext/patches/v14_0/rename_ongoing_status_in_sla_documents.py
@@ -18,4 +18,4 @@
).run()
except Exception:
- frappe.log_error(title="Failed to Patch SLA Status")
+ frappe.log_error("Failed to Patch SLA Status")
diff --git a/erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py b/erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py
index 77c4d7c..34701c1 100644
--- a/erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py
+++ b/erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py
@@ -160,7 +160,7 @@
try:
content = encoded_content.decode("utf-16")
except UnicodeDecodeError as e:
- frappe.log_error(message=e, title="UTF-16 encoding error for File Name: " + file_name)
+ frappe.log_error("UTF-16 encoding error for File Name: " + file_name)
return content
@@ -390,9 +390,7 @@
return pi.name
except Exception as e:
frappe.db.set_value("Import Supplier Invoice", name, "status", "Error")
- frappe.log_error(
- message=e, title="Create Purchase Invoice: " + args.get("bill_no") + "File Name: " + file_name
- )
+ pi.log_error("Unable to create Puchase Invoice")
return None
diff --git a/erpnext/setup/doctype/company/company.py b/erpnext/setup/doctype/company/company.py
index c116458..9bde6e2 100644
--- a/erpnext/setup/doctype/company/company.py
+++ b/erpnext/setup/doctype/company/company.py
@@ -528,7 +528,7 @@
except ImportError:
pass
except Exception:
- frappe.log_error()
+ frappe.log_error("Unable to set country fixtures")
frappe.throw(
_("Failed to setup defaults for country {0}. Please contact support.").format(
frappe.bold(country)
diff --git a/erpnext/setup/setup_wizard/operations/taxes_setup.py b/erpnext/setup/setup_wizard/operations/taxes_setup.py
index 39dc7e3..2f77dd6 100644
--- a/erpnext/setup/setup_wizard/operations/taxes_setup.py
+++ b/erpnext/setup/setup_wizard/operations/taxes_setup.py
@@ -116,7 +116,7 @@
frappe.get_attr(module_name)(country, company)
except Exception as e:
# Log error and ignore if failed to setup regional tax settings
- frappe.log_error()
+ frappe.log_error("Unable to setup regional tax settings")
pass
diff --git a/erpnext/setup/utils.py b/erpnext/setup/utils.py
index 2200e6c..e848dfe 100644
--- a/erpnext/setup/utils.py
+++ b/erpnext/setup/utils.py
@@ -112,7 +112,7 @@
cache.setex(name=key, time=21600, value=flt(value))
return flt(value)
except Exception:
- frappe.log_error(title="Get Exchange Rate")
+ frappe.log_error("Unable to fetch exchange rate")
frappe.msgprint(
_(
"Unable to find exchange rate for {0} to {1} for key date {2}. Please create a Currency Exchange record manually"
diff --git a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
index eb0be46..236b944 100644
--- a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
+++ b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
@@ -135,7 +135,7 @@
except Exception:
frappe.db.rollback()
traceback = frappe.get_traceback()
- frappe.log_error(traceback)
+ doc.log_error("Unable to repost item valuation")
message = frappe.message_log.pop() if frappe.message_log else ""
if traceback:
diff --git a/erpnext/stock/reorder_item.py b/erpnext/stock/reorder_item.py
index ee151b7..4763b47 100644
--- a/erpnext/stock/reorder_item.py
+++ b/erpnext/stock/reorder_item.py
@@ -136,14 +136,14 @@
mr_list = []
exceptions_list = []
- def _log_exception():
+ def _log_exception(mr):
if frappe.local.message_log:
exceptions_list.extend(frappe.local.message_log)
frappe.local.message_log = []
else:
exceptions_list.append(frappe.get_traceback())
- frappe.log_error(frappe.get_traceback())
+ mr.log_error("Unable to create material request")
for request_type in material_requests:
for company in material_requests[request_type]:
@@ -207,7 +207,7 @@
mr_list.append(mr)
except Exception:
- _log_exception()
+ _log_exception(mr)
if mr_list:
if getattr(frappe.local, "reorder_email_notify", None) is None:
diff --git a/erpnext/templates/pages/integrations/gocardless_checkout.py b/erpnext/templates/pages/integrations/gocardless_checkout.py
index 280f67f..655be52 100644
--- a/erpnext/templates/pages/integrations/gocardless_checkout.py
+++ b/erpnext/templates/pages/integrations/gocardless_checkout.py
@@ -96,5 +96,5 @@
return {"redirect_to": redirect_flow.redirect_url}
except Exception as e:
- frappe.log_error(e, "GoCardless Payment Error")
+ frappe.log_error("GoCardless Payment Error")
return {"redirect_to": "/integrations/payment-failed"}
diff --git a/erpnext/templates/pages/integrations/gocardless_confirmation.py b/erpnext/templates/pages/integrations/gocardless_confirmation.py
index cab532a..559aa48 100644
--- a/erpnext/templates/pages/integrations/gocardless_confirmation.py
+++ b/erpnext/templates/pages/integrations/gocardless_confirmation.py
@@ -60,7 +60,7 @@
try:
create_mandate(data)
except Exception as e:
- frappe.log_error(e, "GoCardless Mandate Registration Error")
+ frappe.log_error("GoCardless Mandate Registration Error")
gateway_controller = get_gateway_controller(reference_docname)
frappe.get_doc("GoCardless Settings", gateway_controller).create_payment_request(data)
@@ -68,7 +68,7 @@
return {"redirect_to": confirmation_url}
except Exception as e:
- frappe.log_error(e, "GoCardless Payment Error")
+ frappe.log_error("GoCardless Payment Error")
return {"redirect_to": "/integrations/payment-failed"}
@@ -103,4 +103,4 @@
).insert(ignore_permissions=True)
except Exception:
- frappe.log_error(frappe.get_traceback())
+ frappe.log_error("Gocardless: Unable to create mandate")
diff --git a/erpnext/utilities/doctype/video/video.py b/erpnext/utilities/doctype/video/video.py
index 330812d..a39d0a9 100644
--- a/erpnext/utilities/doctype/video/video.py
+++ b/erpnext/utilities/doctype/video/video.py
@@ -36,8 +36,7 @@
self.comment_count = video_stats.get("commentCount")
except Exception:
- title = "Failed to Update YouTube Statistics for Video: {0}".format(self.name)
- frappe.log_error(title + "\n\n" + frappe.get_traceback(), title=title)
+ self.log_error("Unable to update YouTube statistics")
def is_tracking_enabled():
@@ -109,8 +108,7 @@
video_stats = video.items
return video_stats
except Exception:
- title = "Failed to Update YouTube Statistics"
- frappe.log_error(title + "\n\n" + frappe.get_traceback(), title=title)
+ frappe.log_error("Unable to update YouTube statistics")
def prepare_and_set_data(video_list):
video_ids = get_formatted_ids(video_list)
diff --git a/erpnext/utilities/doctype/video_settings/video_settings.py b/erpnext/utilities/doctype/video_settings/video_settings.py
index 97fbc41..9bc7972 100644
--- a/erpnext/utilities/doctype/video_settings/video_settings.py
+++ b/erpnext/utilities/doctype/video_settings/video_settings.py
@@ -18,5 +18,5 @@
build("youtube", "v3", developerKey=self.api_key)
except Exception:
title = _("Failed to Authenticate the API key.")
- frappe.log_error(title + "\n\n" + frappe.get_traceback(), title=title)
+ self.log_error("Failed to authenticate API key")
frappe.throw(title + " Please check the error logs.", title=_("Invalid Credentials"))