tree 6a3b3ac351a512085244af5204bdc3df87c06e28
parent 9f3276046ff584843cac3f1a140dbc17f9b45d8e
author Joseph Marie Alba <54699674+erpjosephalba@users.noreply.github.com> 1574946200 +0800
committer Nabin Hait <nabinhait@gmail.com> 1574946200 +0530

Fix: Logic bug (#19692)

account_groups = [accounts[d]["account_type"] for d in accounts if accounts[d]['is_group'] not in ('', 1)]
  - if accounts[d]['is_group'] not in ('', 1) is wrong because it returns false even if the account is a group.
  - should be if accounts[d]['is_group'] not in ('', 0)

However, the correction provided here:

    account_groups = [accounts[d]["account_type"] for d in accounts if accounts[d]['is_group'] == 1]

is more consistent with the prior statement that extracts ledger (and not group) accounts.
    account_types = [accounts[d]["account_type"] for d in accounts if not accounts[d]['is_group'] == 1]