tree 1a2be4b36d53d87b8feea56bffbeb1bac171354d
parent fabbf68e0eae62b3be6f36549630f3f4422836b4
author Ankush Menat <ankush@iwebnotes.com> 1633689735 +0530
committer GitHub <noreply@github.com> 1633689735 +0530
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJhYCCHCRBK7hj4Ov3rIwAA50AIAEDq19GZSSJYbeHkhffHSj6E
 VXKxKwSrzNAa11A9LrbBToes5dYFDKqcLK3BQQHkei7bJ05MXTEvdATzBc1Wj8iJ
 TdVqCHJlmVyXzuXQ8YmU7sfSpwbSh7nvnxQaacVd4ZATD+kRsVOcf2bOkLFvxI5S
 44P81LvLaktJuI0MLKRJUUbSNCq0H0+avyoxqnyhFNVd6owh4bs8pPN2LXjRSLpZ
 2N8zydAZaRb5yHyOlYFMFzumrLDeYifWzCZHVG8lV1dvBW4t2O4vroFhIaOw1EqO
 HJ84ZWFxvfxq9SyTAGwCmWYTxQH7/eJ/MMdHWY2C3PsSI1b6vbovM/B39uTJXEU=
 =NWvw
 -----END PGP SIGNATURE-----
 

fix(perf): index creation on voucher_detail_no (#27866)

voucher_detail_no is supposed to have an index, it was added on
on_doctype_update function of table, however this function is only
called if DocType itself is updated and `on_update` is called on
DocType. Stock ledger Entry doctype hasn't changed since addition of
this index in function.

Before: Lack of this index was causing full table scan in
get_future_sle_to_fix function. (~50 seconds in a reposting job)

After: Single row is fetched (~0.5 second in full reposting job)

Learnings:
1. Add simple indexes via doctype only
2. For complex indexes always change doctype.json file for it to take
   effect.