commit 61b4afc3c54d7851f8775104ffbe3be332f9a9a9
author Faris Ansari <netchampfaris@users.noreply.github.com> Mon Apr 29 22:41:24 2019 +0530
committer GitHub <noreply@github.com> Mon Apr 29 22:41:24 2019 +0530
tree f336834f33609c72cb4c663371d5acffd0f5ed52
parent 9f660267c13f970ed5ac4bc32f98323dc0c78bb0

perf: Order by name instead of parent (#17404)

Changing the order by column reduced the query time from 60s to 12s

erpnext/portal/product_configurator/item_variants_cache.py

diff --git a/erpnext/portal/product_configurator/item_variants_cache.py b/erpnext/portal/product_configurator/item_variants_cache.py
index 458c229..f17639c 100644
--- a/erpnext/portal/product_configurator/item_variants_cache.py
+++ b/erpnext/portal/product_configurator/item_variants_cache.py
@@ -62,7 +62,7 @@
 
 		item_variants_data = frappe.db.get_all('Item Variant Attribute',
 			{'variant_of': parent_item_code}, ['parent', 'attribute', 'attribute_value'],
-			order_by='parent',
+			order_by='name',
 			as_list=1
 		)