commit 65c8466622c69a64bb904aa7cd1059c61949c3e0
author Manas Solanki <manas@erpnext.com> Fri May 05 17:28:09 2017 +0530
committer Nabin Hait <nabinhait@gmail.com> Fri May 05 17:28:09 2017 +0530
tree 7b5923f6e52f337f5de47db42f0bafc9a3f5cfeb
parent 42343bbc2cd300241d95b87f70a116902eb1e4d3

check for mandatory field before frappe.call (#8705)

erpnext/schools/doctype/student_group/student_group.js

diff --git a/erpnext/schools/doctype/student_group/student_group.js b/erpnext/schools/doctype/student_group/student_group.js
index c2c6912..ed94690 100644
--- a/erpnext/schools/doctype/student_group/student_group.js
+++ b/erpnext/schools/doctype/student_group/student_group.js
@@ -42,7 +42,7 @@
 	},
 
 	get_students: function(frm) {
-		if (frm.doc.group_based_on != "Activity") {
+		if (frm.doc.group_based_on == "Batch" || frm.doc.group_based_on == "Course") {
 			var student_list = [];
 			var max_roll_no = 0;
 			$.each(frm.doc.students, function(i,d) {