commit 7a8c5b0c2c019063c5c98e4c1323ec6d0a4575a3
author Faris Ansari <netchampfaris@users.noreply.github.com> Tue Sep 25 18:34:33 2018 +0530
committer Nabin Hait <nabinhait@gmail.com> Tue Sep 25 18:34:33 2018 +0530
tree be4a8afc6c8d48b559593cc81bca2547e089efeb
parent 056ecdca6a07996f8045ca3a353a2e176482310f

fix(setup wizard): Validate FY dates (#15473)

erpnext/public/js/setup_wizard.js

diff --git a/erpnext/public/js/setup_wizard.js b/erpnext/public/js/setup_wizard.js
index 6fa710d..484d81d 100644
--- a/erpnext/public/js/setup_wizard.js
+++ b/erpnext/public/js/setup_wizard.js
@@ -138,10 +138,15 @@
 
 		validate: function () {
 			// validate fiscal year start and end dates
-			if (this.values.fy_start_date == 'Invalid date' || this.values.fy_end_date == 'Invalid date') {
+			const invalid = this.values.fy_start_date == 'Invalid date' ||
+				this.values.fy_end_date == 'Invalid date';
+			const start_greater_than_end = this.values.fy_start_date > this.values.fy_end_date;
+
+			if (invalid || start_greater_than_end) {
 				frappe.msgprint(__("Please enter valid Financial Year Start and End Dates"));
 				return false;
 			}
+
 			return true;
 		},