commit 7b385046b6a7fd15ed60c72fa315e99c3125887b
author Afshan <33727827+AfshanKhan@users.noreply.github.com> Wed Dec 23 14:34:37 2020 +0530
committer GitHub <noreply@github.com> Wed Dec 23 14:34:37 2020 +0530
tree e8dd8e95dc68bf812f344c23a2fa07ef8514110d
parent 0a1390a7ca2c67f53c33119bb429e2f8efaaf943
parent adf9b49e1462862a7743026def8bb7e1a3c48311

Merge pull request #24192 from AfshanKhan/sal-slip-pop-up-error

fix: sal slip popup error

erpnext/payroll/doctype/salary_slip/salary_slip.js

diff --git a/erpnext/payroll/doctype/salary_slip/salary_slip.js b/erpnext/payroll/doctype/salary_slip/salary_slip.js
index f7e22c6..abe873d 100644
--- a/erpnext/payroll/doctype/salary_slip/salary_slip.js
+++ b/erpnext/payroll/doctype/salary_slip/salary_slip.js
@@ -214,14 +214,16 @@
 });
 
 var calculate_totals = function(frm) {
-	if (frm.doc.earnings || frm.doc.deductions) {
-		frappe.call({
-			method: "set_totals",
-			doc: frm.doc,
-			callback: function() {
-				frm.refresh_fields();
-			}
-		});
+	if (frm.doc.docstatus === 0) {
+		if (frm.doc.earnings || frm.doc.deductions) {
+			frappe.call({
+				method: "set_totals",
+				doc: frm.doc,
+				callback: function() {
+					frm.refresh_fields();
+				}
+			});
+		}
 	}
 };