| commit | 9229ee1745d864656ddee0b216a33078b7a932c6 | [log] [tgz] |
|---|---|---|
| author | Ankush Menat <ankush@iwebnotes.com> | Sat Apr 17 15:41:10 2021 +0530 |
| committer | Ankush Menat <ankush@iwebnotes.com> | Sun Apr 18 13:22:19 2021 +0530 |
| tree | ca2f1f52f743d852e020640f560fd54a4aa5c976 | |
| parent | 72e3a81878b68cfc27aeb114d90c8813530c8300 [diff] |
fix: update shipment status in database Caught by semgrep rule: https://github.com/frappe/erpnext/blob/develop/.github/helper/semgrep_rules/frappe_correctness.yml#L4
diff --git a/erpnext/stock/doctype/shipment/shipment.py b/erpnext/stock/doctype/shipment/shipment.py index 4697a7b..01fcee4 100644 --- a/erpnext/stock/doctype/shipment/shipment.py +++ b/erpnext/stock/doctype/shipment/shipment.py
@@ -23,10 +23,10 @@ frappe.throw(_('Please enter Shipment Parcel information')) if self.value_of_goods == 0: frappe.throw(_('Value of goods cannot be 0')) - self.status = 'Submitted' + self.db_set('status', 'Submitted') def on_cancel(self): - self.status = 'Cancelled' + self.db_set('status', 'Cancelled') def validate_weight(self): for parcel in self.shipment_parcel: