commit 98468fab18e08de440f2f6731759d221fe08c416
author Ankush Menat <ankush@frappe.io> Sun Mar 27 22:15:38 2022 +0530
committer Ankush Menat <ankushmenat@gmail.com> Mon Mar 28 12:07:00 2022 +0530
tree 213e5c04c301c3a49c8c45b25f0571c8a11ea1d4
parent 806f420ddd396819e6aa36fe36d6fbd3e1c28c8e

fix: ignore circular dependencies on barcode scan

erpnext/public/js/controllers/transaction.js

diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js
index 6196392..23c2bd4 100644
--- a/erpnext/public/js/controllers/transaction.js
+++ b/erpnext/public/js/controllers/transaction.js
@@ -404,11 +404,13 @@
 	}
 
 	barcode(doc, cdt, cdn) {
-		var d = locals[cdt][cdn];
-		if(d.barcode=="" || d.barcode==null) {
+		const d = locals[cdt][cdn];
+		if (!d.barcode) {
 			// barcode cleared, remove item
 			d.item_code = "";
 		}
+		// flag required for circular triggers
+		d._triggerd_from_barcode = true;
 		this.item_code(doc, cdt, cdn);
 	}
 
@@ -429,7 +431,9 @@
 			this.frm.doc.doctype === 'Delivery Note') {
 			show_batch_dialog = 1;
 		}
-		item.barcode = null;
+		if (!item._triggerd_from_barcode) {
+			item.barcode = null;
+		}
 
 
 		if(item.item_code || item.barcode || item.serial_no) {