commit a34a1f8fd26849993f4d66df740273fabd066d55
author Deepesh Garg <deepeshgarg6@gmail.com> Sun Jan 29 21:34:28 2023 +0530
committer GitHub <noreply@github.com> Sun Jan 29 21:34:28 2023 +0530
tree ac1fc40d333c4addeefaa2457569d3888a361703
parent faecf3ee405abec3edf95fd9bf7790608852c2b5

fix: Amount validation in Payment Request against Purchase Order (#33855)

fix: Amount validation in Payment Request againt Purchase Order

erpnext/accounts/doctype/payment_request/payment_request.py

diff --git a/erpnext/accounts/doctype/payment_request/payment_request.py b/erpnext/accounts/doctype/payment_request/payment_request.py
index 4fc12db..fc837c7 100644
--- a/erpnext/accounts/doctype/payment_request/payment_request.py
+++ b/erpnext/accounts/doctype/payment_request/payment_request.py
@@ -51,7 +51,7 @@
 
 		if existing_payment_request_amount:
 			ref_doc = frappe.get_doc(self.reference_doctype, self.reference_name)
-			if hasattr(ref_doc, "order_type") and getattr(ref_doc, "order_type") != "Shopping Cart":
+			if not hasattr(ref_doc, "order_type") or getattr(ref_doc, "order_type") != "Shopping Cart":
 				ref_amount = get_amount(ref_doc, self.payment_account)
 
 				if existing_payment_request_amount + flt(self.grand_total) > ref_amount: