Merge pull request #13430 from codingCoffee/child_doc_perm_fix
Permisssion fixes for child table
diff --git a/erpnext/stock/get_item_details.py b/erpnext/stock/get_item_details.py
index a0f7f43..cafa4bc 100644
--- a/erpnext/stock/get_item_details.py
+++ b/erpnext/stock/get_item_details.py
@@ -319,7 +319,7 @@
out.price_list_rate = flt(price_list_rate) * flt(args.plc_conversion_rate) \
/ flt(args.conversion_rate)
if not args.price_list_uom_dependant:
- out.price_list_rate = flt(out.price_list_rate * (args.conversion_factor or 1.0))
+ out.price_list_rate = flt(out.price_list_rate * (flt(args.conversion_factor) or 1.0))
if not out.price_list_rate and args.transaction_type=="buying":
from erpnext.stock.doctype.item.item import get_last_purchase_details
diff --git a/erpnext/stock/report/item_variant_details/item_variant_details.py b/erpnext/stock/report/item_variant_details/item_variant_details.py
index f1488f8..7379eb4 100644
--- a/erpnext/stock/report/item_variant_details/item_variant_details.py
+++ b/erpnext/stock/report/item_variant_details/item_variant_details.py
@@ -14,10 +14,15 @@
if not item:
return []
item_dicts = []
+ variants = None
variant_results = frappe.db.sql("""select name from `tabItem`
where variant_of = %s""", item, as_dict=1)
- variants = ",".join(['"' + frappe.db.escape(variant['name']) + '"' for variant in variant_results])
+ if not variant_results:
+ frappe.msgprint(_("There isn't any item variant for the selected item"))
+ return []
+ else:
+ variants = ",".join(['"' + frappe.db.escape(variant['name']) + '"' for variant in variant_results])
order_count_map = get_open_sales_orders_map(variants)
stock_details_map = get_stock_details_map(variants)