| commit | a7d448dcbaa11280fa973d08f912bec1a3a445cb | [log] [tgz] |
|---|---|---|
| author | John Clarke <clarkejjm@gmail.com> | Thu Sep 05 03:25:35 2019 -0600 |
| committer | Nabin Hait <nabinhait@gmail.com> | Thu Sep 05 14:55:35 2019 +0530 |
| tree | 335000de21ff103ab3d81e663082725c78be71c1 | |
| parent | 77da3b4347ade309d1547e872c1fb9b89b71775f [diff] |
fix: Error "TypeError: unorderable types: int() > str()" When Trying to Create Packing Slip (#18913) User report here https://discuss.erpnext.com/t/error-typeerror-unorderable-types-int-str-when-trying-to-create-packing-slip/52445 This has not been noted to github issues and is just a suggested fix, an expert may need to refactor more here? User and traceback does not state whether Python 2 or 3 but perhaps 3 since that apparently does not 'guess' when types do not match? See also https://stackoverflow.com/questions/14886881/unorderable-types-int-str
diff --git a/erpnext/stock/doctype/packing_slip/packing_slip.py b/erpnext/stock/doctype/packing_slip/packing_slip.py index b99215c..4139a19 100644 --- a/erpnext/stock/doctype/packing_slip/packing_slip.py +++ b/erpnext/stock/doctype/packing_slip/packing_slip.py
@@ -49,7 +49,7 @@ frappe.msgprint(_("Please specify a valid 'From Case No.'"), raise_exception=1) elif not self.to_case_no: self.to_case_no = self.from_case_no - elif self.from_case_no > self.to_case_no: + elif cint(self.from_case_no) > cint(self.to_case_no): frappe.msgprint(_("'To Case No.' cannot be less than 'From Case No.'"), raise_exception=1)