commit ab14892fc5ab2138135ec508b35ee62433006b6d
author Faris Ansari <netchamp.faris@gmail.com> Fri May 03 13:57:20 2019 +0530
committer Faris Ansari <netchamp.faris@gmail.com> Fri May 03 13:57:20 2019 +0530
tree 5ad76876aa4ec9aa9cf944c8359a42d1af6bc429
parent cb03bb1c00d665180bb90e2f54233d6b1d8ccf49

fix: Variant naming if optional attributes

erpnext/controllers/item_variant.py

diff --git a/erpnext/controllers/item_variant.py b/erpnext/controllers/item_variant.py
index d0d893a..631f775 100644
--- a/erpnext/controllers/item_variant.py
+++ b/erpnext/controllers/item_variant.py
@@ -309,7 +309,7 @@
 			}, as_dict=True)
 
 		if not item_attribute:
-			return
+			continue
 			# frappe.throw(_('Invalid attribute {0} {1}').format(frappe.bold(attr.attribute),
 			# 	frappe.bold(attr.attribute_value)), title=_('Invalid Attribute'),
 			# 	exc=InvalidItemAttributeValueError)