commit b44945380dd0af192b12cdf96df7ac23b77a79c3
author Noah Jacob <noahjacobkurian@gmail.com> Wed Oct 20 17:37:52 2021 +0530
committer Ankush Menat <ankushmenat@gmail.com> Fri Oct 29 16:56:15 2021 +0530
tree 13c498c504b58c6e545e71f8a0303897bec71efa
parent 75a76e634d17507a568ff007d20226ffa8f7dff3

fix: incorrect amount of serial_nos fetched

erpnext/stock/utils.py

diff --git a/erpnext/stock/utils.py b/erpnext/stock/utils.py
index c4a0497..b131125 100644
--- a/erpnext/stock/utils.py
+++ b/erpnext/stock/utils.py
@@ -104,7 +104,7 @@
 			serial_nos = last_entry.get("serial_no")
 
 			if (serial_nos and
-				len(get_serial_nos_data(serial_nos)) < last_entry.qty_after_transaction):
+				len(get_serial_nos_data(serial_nos)) <= last_entry.qty_after_transaction):
 				serial_nos = get_serial_nos_data_after_transactions(args)
 
 			return ((last_entry.qty_after_transaction, last_entry.valuation_rate, serial_nos)
@@ -121,6 +121,7 @@
 		WHERE
 			item_code = %(item_code)s and warehouse = %(warehouse)s
 			and timestamp(posting_date, posting_time) < timestamp(%(posting_date)s, %(posting_time)s)
+			and is_cancelled = 0
 			order by posting_date, posting_time asc """, args, as_dict=1)
 
 	for d in data: