commit b58b1343bb80f3442f49728e965f834a35d2f257
author Ankush Menat <ankush@frappe.io> Mon Mar 28 10:19:22 2022 +0530
committer Ankush Menat <ankushmenat@gmail.com> Mon Mar 28 12:07:00 2022 +0530
tree 0e14b3fb263124ef81e831eba333e6343957d20a
parent 98468fab18e08de440f2f6731759d221fe08c416

refactor: dont harcode "serial_no" field

erpnext/public/js/utils/barcode_scanner.js

diff --git a/erpnext/public/js/utils/barcode_scanner.js b/erpnext/public/js/utils/barcode_scanner.js
index c6c3938..abea5fc 100644
--- a/erpnext/public/js/utils/barcode_scanner.js
+++ b/erpnext/public/js/utils/barcode_scanner.js
@@ -145,7 +145,8 @@
 	}
 
 	is_duplicate_serial_no(row, serial_no) {
-		const is_duplicate = !!serial_no && !!row.serial_no && row.serial_no.includes(serial_no);
+		const is_duplicate = !!serial_no && !!row[this.serial_no_field]
+			&& row[this.serial_no_field].includes(serial_no);
 
 		if (is_duplicate) {
 			frappe.show_alert(