Merge pull request #40707 from s-aga-r/FIX-12241
fix(ux): Sales Order Stock Reservation Dialog
diff --git a/erpnext/selling/doctype/sales_order/sales_order.js b/erpnext/selling/doctype/sales_order/sales_order.js
index 69bbae3..99d9799 100644
--- a/erpnext/selling/doctype/sales_order/sales_order.js
+++ b/erpnext/selling/doctype/sales_order/sales_order.js
@@ -288,6 +288,7 @@
label: __("Items to Reserve"),
allow_bulk_edit: false,
cannot_add_rows: true,
+ cannot_delete_rows: true,
data: [],
fields: [
{
@@ -356,7 +357,7 @@
],
primary_action_label: __("Reserve Stock"),
primary_action: () => {
- var data = { items: dialog.fields_dict.items.grid.data };
+ var data = { items: dialog.fields_dict.items.grid.get_selected_children() };
if (data.items && data.items.length > 0) {
frappe.call({
@@ -373,9 +374,11 @@
frm.reload_doc();
},
});
- }
- dialog.hide();
+ dialog.hide();
+ } else {
+ frappe.msgprint(__("Please select items to reserve."));
+ }
},
});
@@ -390,6 +393,7 @@
if (unreserved_qty > 0) {
dialog.fields_dict.items.df.data.push({
+ __checked: 1,
sales_order_item: item.name,
item_code: item.item_code,
warehouse: item.warehouse,
@@ -414,6 +418,7 @@
label: __("Reserved Stock"),
allow_bulk_edit: false,
cannot_add_rows: true,
+ cannot_delete_rows: true,
in_place_edit: true,
data: [],
fields: [
@@ -457,7 +462,7 @@
],
primary_action_label: __("Unreserve Stock"),
primary_action: () => {
- var data = { sr_entries: dialog.fields_dict.sr_entries.grid.data };
+ var data = { sr_entries: dialog.fields_dict.sr_entries.grid.get_selected_children() };
if (data.sr_entries && data.sr_entries.length > 0) {
frappe.call({
@@ -473,9 +478,11 @@
frm.reload_doc();
},
});
- }
- dialog.hide();
+ dialog.hide();
+ } else {
+ frappe.msgprint(__("Please select items to unreserve."));
+ }
},
});