account cleanup, added toggle_fields in cur_frm
diff --git a/erpnext/accounts/doctype/account/account.js b/erpnext/accounts/doctype/account/account.js
index b72dc8d..79c15bf 100644
--- a/erpnext/accounts/doctype/account/account.js
+++ b/erpnext/accounts/doctype/account/account.js
@@ -18,22 +18,35 @@
// Onload
// -----------------------------------------
cur_frm.cscript.onload = function(doc, cdt, cdn) {
- cur_frm.cscript.account_type(doc, cdt, cdn);
- // hide India specific fields
- var cp = wn.control_panel;
- if(cp.country == 'India')
- unhide_field(['pan_number', 'tds_applicable', 'tds_details', 'tds']);
- else
- hide_field(['pan_number', 'tds_applicable', 'tds_details', 'tds']);
}
// Refresh
// -----------------------------------------
cur_frm.cscript.refresh = function(doc, cdt, cdn) {
- root_acc = [' Application of Funds (Assets)','Expenses','Income','Source of Funds (Liabilities)'];
- if(inList(root_acc, doc.account_name))
- cur_frm.perm = [[1,0,0], [1,0,0]];
- cur_frm.cscript.hide_unhide_group_ledger(doc);
+ // read-only for root accounts
+ root_acc = ['Application of Funds (Assets)','Expenses','Income','Source of Funds (Liabilities)'];
+ if(inList(root_acc, doc.account_name))
+ cur_frm.perm = [[1,0,0], [1,0,0]];
+
+ // hide fields if group
+ cur_frm.toggle_fields(['account_type', 'master_type', 'master_name', 'freeze_account',
+ 'credit_days', 'credit_limit'], doc.group_or_ledger=='Ledger')
+
+ // credit days and type if customer or supplier
+ cur_frm.toggle_fields(['credit_days', 'credit_limit'],
+ in_list(['Customer', 'Supplier'], doc.master_type))
+
+ // hide tax_rate
+ cur_frm.cscript.account_type(doc, cdt, cdn);
+
+ // show / hide convert buttons
+ cur_frm.cscript.hide_unhide_group_ledger(doc);
+
+ // back to chart of accounts
+ cur_frm.add_custom_button('Back To Chart of Accounts', function() {
+ wn.set_route('Accounts Browser', 'Account');
+ }, 'icon-arrow-left')
+
}
// Fetch parent details
@@ -44,8 +57,8 @@
// Hide tax rate based on account type
// -----------------------------------------
cur_frm.cscript.account_type = function(doc, cdt, cdn) {
- if(doc.account_type == 'Tax') unhide_field(['tax_rate']);
- else hide_field(['tax_rate']);
+ cur_frm.toggle_fields(['tax_rate'], doc.account_type == 'Tax')
+ cur_frm.toggle_fields(['master_type', 'master_name'], cstr(doc.account_type)=='')
}
// Hide/unhide group or ledger
@@ -88,11 +101,13 @@
if (doc.master_type){
return 'SELECT `tab'+doc.master_type+'`.name FROM `tab'+doc.master_type+'` WHERE `tab'+doc.master_type+'`.name LIKE "%s" and `tab'+doc.master_type+'`.docstatus != 2 ORDER BY `tab'+doc.master_type+'`.name LIMIT 50';
}
- else alert("Please select master type");
}
// parent account get query
// -----------------------------------------
cur_frm.fields_dict['parent_account'].get_query = function(doc){
- return 'SELECT DISTINCT `tabAccount`.name FROM `tabAccount` WHERE `tabAccount`.group_or_ledger="Group" AND `tabAccount`.docstatus != 2 AND `tabAccount`.company="'+ doc.company+'" AND `tabAccount`.company is not NULL AND `tabAccount`.name LIKE "%s" ORDER BY `tabAccount`.name LIMIT 50';
+ return 'SELECT DISTINCT `tabAccount`.name FROM `tabAccount` WHERE \
+ `tabAccount`.group_or_ledger="Group" AND `tabAccount`.docstatus != 2 AND \
+ `tabAccount`.company="'+ doc.company+'" AND `tabAccount`.company is not NULL AND \
+ `tabAccount`.name LIKE "%s" ORDER BY `tabAccount`.name LIMIT 50';
}
diff --git a/erpnext/accounts/doctype/account/account.txt b/erpnext/accounts/doctype/account/account.txt
index 1dd023c..e3ec85a 100644
--- a/erpnext/accounts/doctype/account/account.txt
+++ b/erpnext/accounts/doctype/account/account.txt
@@ -5,7 +5,7 @@
{
'creation': '2012-07-03 13:30:50',
'docstatus': 0,
- 'modified': '2012-07-10 18:34:16',
+ 'modified': '2012-07-11 09:21:01',
'modified_by': u'Administrator',
'owner': u'Administrator'
},
@@ -296,6 +296,8 @@
# DocField
{
+ 'colour': u'White:FFF',
+ 'description': u'Setting Account Type helps in selecting this Account in transactions.',
'doctype': u'DocField',
'fieldname': u'account_type',
'fieldtype': u'Select',
@@ -312,7 +314,7 @@
# DocField
{
'colour': u'White:FFF',
- 'description': u'If Account Type is "Tax" then the default rate is required.',
+ 'description': u'Rate at which this tax is applied',
'doctype': u'DocField',
'fieldname': u'tax_rate',
'fieldtype': u'Currency',
@@ -340,6 +342,7 @@
# DocField
{
+ 'colour': u'White:FFF',
'doctype': u'DocField',
'fieldname': u'credit_days',
'fieldtype': u'Int',
@@ -366,13 +369,15 @@
# DocField
{
+ 'colour': u'White:FFF',
+ 'description': u'If this Account represents a Customer, Supplier or Employee, set it here.',
'doctype': u'DocField',
'fieldname': u'master_type',
'fieldtype': u'Select',
'label': u'Master Type',
'oldfieldname': u'master_type',
'oldfieldtype': u'Select',
- 'options': u'\nNA\nSupplier\nCustomer\nEmployee',
+ 'options': u'\nSupplier\nCustomer\nEmployee',
'permlevel': 0
},
@@ -386,116 +391,5 @@
'oldfieldtype': u'Link',
'permlevel': 0,
'trigger': u'Client'
- },
-
- # DocField
- {
- 'doctype': u'DocField',
- 'fieldname': u'tds',
- 'fieldtype': u'Section Break',
- 'label': u'TDS',
- 'oldfieldtype': u'Section Break',
- 'permlevel': 0
- },
-
- # DocField
- {
- 'doctype': u'DocField',
- 'fieldname': u'pan_number',
- 'fieldtype': u'Data',
- 'label': u'PAN Number',
- 'oldfieldname': u'pan_number',
- 'oldfieldtype': u'Data',
- 'permlevel': 0
- },
-
- # DocField
- {
- 'default': u'No',
- 'doctype': u'DocField',
- 'fieldname': u'tds_applicable',
- 'fieldtype': u'Select',
- 'label': u'TDS Applicable',
- 'oldfieldname': u'tds_applicable',
- 'oldfieldtype': u'Select',
- 'options': u'\nYes\nNo',
- 'permlevel': 0
- },
-
- # DocField
- {
- 'doctype': u'DocField',
- 'fieldname': u'tds_details',
- 'fieldtype': u'Table',
- 'label': u'TDS Details',
- 'oldfieldname': u'tds_details',
- 'oldfieldtype': u'Table',
- 'options': u'TDS Detail',
- 'permlevel': 0
- },
-
- # DocField
- {
- 'description': u"Don't delete this field at any cost",
- 'doctype': u'DocField',
- 'fieldname': u'old_parent',
- 'fieldtype': u'Link',
- 'hidden': 1,
- 'label': u'Old Parent',
- 'no_copy': 1,
- 'oldfieldname': u'old_parent',
- 'oldfieldtype': u'Data',
- 'options': u'Account',
- 'permlevel': 0,
- 'report_hide': 1
- },
-
- # DocField
- {
- 'colour': u'White:FFF',
- 'description': u"Don't delete this field at any cost",
- 'doctype': u'DocField',
- 'fieldname': u'lft',
- 'fieldtype': u'Int',
- 'hidden': 1,
- 'in_filter': 1,
- 'label': u'Lft',
- 'no_copy': 1,
- 'oldfieldname': u'lft',
- 'oldfieldtype': u'Int',
- 'permlevel': 3,
- 'print_hide': 1,
- 'report_hide': 1,
- 'search_index': 1
- },
-
- # DocField
- {
- 'colour': u'White:FFF',
- 'description': u"Don't delete this field at any cost",
- 'doctype': u'DocField',
- 'fieldname': u'rgt',
- 'fieldtype': u'Int',
- 'hidden': 1,
- 'in_filter': 1,
- 'label': u'Rgt',
- 'no_copy': 1,
- 'oldfieldname': u'rgt',
- 'oldfieldtype': u'Int',
- 'permlevel': 3,
- 'print_hide': 1,
- 'report_hide': 1,
- 'search_index': 1
- },
-
- # DocField
- {
- 'doctype': u'DocField',
- 'fieldname': u'trash_reason',
- 'fieldtype': u'Small Text',
- 'label': u'Trash Reason',
- 'oldfieldname': u'trash_reason',
- 'oldfieldtype': u'Small Text',
- 'permlevel': 1
}
]
\ No newline at end of file
diff --git a/public/css/all-app.css b/public/css/all-app.css
index e5e68a1..6bd1d58 100644
--- a/public/css/all-app.css
+++ b/public/css/all-app.css
@@ -2284,23 +2284,13 @@
}
.help_box, .help-box {
- background-color:#FFC;
- font-size: 13px;
- color: #864;
- padding: 7px;
+ background-color: #ffe;
+ color: #874;
+ padding: 9px 9px 9px 9px;
+ border: 1px dashed #fc7;
margin: 11px 0px;
- border: 1px solid #EEB;
}
-.help_box_big {
- background-color:#FFC;
- color: #864;
- padding: 7px;
- margin: 7px 0px;
- border: 1px solid #EEB;
- text-align: center;
- font-size: 14px;
-}
/*
* lib/css/legacy/forms.css
@@ -2320,10 +2310,8 @@
}
div.form-intro-area {
- background-color: #ffe;
padding: 9px 9px 0px 9px;
- border: 1px dashed #fc7;
- margin-bottom: 15px;
+ margin: 0px 0px 15px 0px;
}
div.form-section-head {
diff --git a/public/css/all-web.css b/public/css/all-web.css
index a3b6de5..e1311c4 100644
--- a/public/css/all-web.css
+++ b/public/css/all-web.css
@@ -2145,23 +2145,13 @@
}
.help_box, .help-box {
- background-color:#FFC;
- font-size: 13px;
- color: #864;
- padding: 7px;
+ background-color: #ffe;
+ color: #874;
+ padding: 9px 9px 9px 9px;
+ border: 1px dashed #fc7;
margin: 11px 0px;
- border: 1px solid #EEB;
}
-.help_box_big {
- background-color:#FFC;
- color: #864;
- padding: 7px;
- margin: 7px 0px;
- border: 1px solid #EEB;
- text-align: center;
- font-size: 14px;
-}
/*
* lib/css/legacy/dialog.css
diff --git a/public/js/all-app.js b/public/js/all-app.js
index d7cfcd1..d0e4771 100644
--- a/public/js/all-app.js
+++ b/public/js/all-app.js
@@ -1220,14 +1220,14 @@
* lib/js/legacy/webpage/search.js
*/
search_fields={};function setlinkvalue(name){selector.input.set_input_value(name);selector.hide();}
-function makeselector(){var d=new Dialog(540,440,'Search');d.make_body([['Data','Beginning With','Tip: You can use wildcard "%"'],['Select','Search By'],['Button','Search'],['HTML','Help'],['HTML','Result']]);var inp=d.widgets['Beginning With'];var field_sel=d.widgets['Search By'];var btn=d.widgets['Search'];d.sel_type='';d.values_len=0;d.set=function(input,type,label){d.sel_type=type;d.input=input;if(d.style!='Link'){d.rows['Result'].innerHTML='';d.values_len=0;}
+function makeselector(){var d=new Dialog(540,440,'Search');d.make_body([['HTML','Help'],['Data','Beginning With','Tip: You can use wildcard "%"'],['Select','Search By'],['Button','Search'],['HTML','Result']]);var inp=d.widgets['Beginning With'];var field_sel=d.widgets['Search By'];var btn=d.widgets['Search'];d.sel_type='';d.values_len=0;d.set=function(input,type,label){d.sel_type=type;d.input=input;if(d.style!='Link'){d.rows['Result'].innerHTML='';d.values_len=0;}
d.style='Link';d.set_query_description()
-if(!d.sel_type)d.sel_type='Value';d.set_title('Select a "'+d.sel_type+'" for field "'+label+'"');}
+if(!d.sel_type)d.sel_type='Value';d.set_title("Select");d.set_query_description('Select a "'+d.sel_type+'" for field "'+label+'"');}
d.set_search=function(dt){if(d.style!='Search'){d.rows['Result'].innerHTML='';d.values_len=0;}
d.style='Search';if(d.input){d.input=null;sel_type=null;}
d.sel_type=get_label_doctype(dt);d.set_title('Quick Search for '+dt);}
$(inp).keydown(function(e){if(e.which==13){if(!btn.disabled)btn.onclick();}})
-d.set_query_description=function(){if(d.input&&d.input.query_description){d.rows['Help'].innerHTML='<div class="help_box">'+d.input.query_description+'</div>';}else{d.rows['Help'].innerHTML=''}}
+d.set_query_description=function(txt){if(!txt)txt=d.input&&d.input.query_description||null;if(txt){d.rows['Help'].innerHTML='<div class="help-box" style="margin-top:0px">'+txt+'</div>';}else{d.rows['Help'].innerHTML=''}}
d.onshow=function(){if(d.set_doctype!=d.sel_type){d.rows['Result'].innerHTML='';d.values_len=0;}
inp.value='';if(d.input&&d.input.txt.value){inp.value=d.input.txt.value;}
try{inp.focus();}catch(e){}
@@ -1743,7 +1743,7 @@
_f.Frm.prototype.setup_sidebar=function(){this.sidebar=new wn.widgets.form.sidebar.Sidebar(this);}
_f.Frm.prototype.setup_footer=function(){var me=this;var f=this.page_layout.footer;f.save_area=$a(this.page_layout.footer,'div','',{display:'none',marginTop:'11px'});f.help_area=$a(this.page_layout.footer,'div');var b=$btn(f.save_area,'Save',function(){cur_frm.save('Save');},{marginLeft:'0px'},'green');f.show_save=function(){$ds(me.page_layout.footer.save_area);}
f.hide_save=function(){$dh(me.page_layout.footer.save_area);}}
-_f.Frm.prototype.set_intro=function(txt){if(!this.intro_area){this.intro_area=$('<div class="form-intro-area">').insertBefore(this.page_layout.body.firstChild);}
+_f.Frm.prototype.set_intro=function(txt){if(!this.intro_area){this.intro_area=$('<div class="help-box form-intro-area">').insertBefore(this.page_layout.body.firstChild);}
if(txt){this.intro_area.html(txt);}else{this.intro_area.remove();this.intro_area=null;}}
_f.Frm.prototype.setup_fields_std=function(){var fl=wn.meta.docfield_list[this.doctype];fl.sort(function(a,b){return a.idx-b.idx});if(fl[0]&&fl[0].fieldtype!="Section Break"||get_url_arg('embed')){this.layout.addrow();if(fl[0].fieldtype!="Column Break"){var c=this.layout.addcell();$y(c.wrapper,{padding:'8px'});}}
var sec;for(var i=0;i<fl.length;i++){var f=fl[i];if(f.fieldtype=='Section Break'&&fl[i+1]&&fl[i+1].fieldtype=='Section Break')
@@ -1851,6 +1851,8 @@
cur_frm.comments.list.dt=cur_frm.doctype;cur_frm.comments.list.dn=cur_frm.docname;cur_frm.comments.show();cur_frm.comments.list.run();}
_f.Frm.prototype.get_doc=function(){return locals[this.doctype][this.docname];}
_f.Frm.prototype.get_doclist=function(){return make_doclist(this.doctype,this.docname);}
+_f.Frm.prototype.toggle_fields=function(fields,show){if(show){unhide_field(fields)}
+else{hide_field(fields)}}
/*
* lib/js/legacy/widgets/form/form_fields.js
*/
@@ -1939,7 +1941,7 @@
$(document).bind('click',function(e){var me=this;var is_target_toolbar=function(){return $(e.target).parents('.grid_tbarlinks').length;}
var is_target_input=function(){if(e.target.tagName.toLowerCase()=='option')return true;return $(e.target).parents().get().indexOf(_f.cur_grid_cell)!=-1;}
if(_f.cur_grid_cell&&!is_target_input()&&!is_target_toolbar()){if(!(text_dialog&&text_dialog.display)&&!datepicker_active&&!(selector&&selector.display)){setTimeout('_f.cur_grid_cell.grid.cell_deselect()',500);return false;}}});_f.Grid.prototype.cell_deselect=function(){if(_f.cur_grid_cell){var c=_f.cur_grid_cell;c.grid.remove_template(c);c.div.className='grid_cell_div';if(c.is_odd)c.div.style.border='2px solid '+c.grid.alt_row_bg;else c.div.style.border='2px solid #FFF';_f.cur_grid_cell=null;}}
-_f.Grid.prototype.cell_select=function(cell,ri,ci){if(_f.cur_grid_cell==cell&&cell.hc)return;if(ri!=null&&ci!=null)
+_f.Grid.prototype.cell_select=function(cell,ri,ci){if(cell&&_f.cur_grid_cell==cell&&cell.hc)return;if(ri!=null&&ci!=null)
cell=this.tab.rows[ri].cells[ci];var hc=this.head_row.cells[cell.cellIndex];if(!hc.template){this.make_template(hc);}
hc.template.perm=this.field?this.field.perm:hc.perm;if(hc.fieldname&&hc.template.get_status()=='Write'){this.cell_deselect();cell.div.style.border='2px solid #88F';_f.cur_grid_cell=cell;this.add_template(cell);}}
_f.Grid.prototype.add_template=function(cell){if(!cell.row.docname&&this.add_newrow){this.add_newrow();this.cell_select(cell);}else{var hc=this.head_row.cells[cell.cellIndex];cell.div.innerHTML='';cell.div.appendChild(hc.template.wrapper);hc.template.activate(cell.row.docname);hc.template.activated=1;cell.hc=hc;if(hc.template.input&&hc.template.input.set_width){hc.template.input.set_width($(cell).width());}}}
@@ -1995,7 +1997,7 @@
_f.FormGrid.prototype.check_selected=function(){if(!_f.cur_grid_cell){show_alert('Select a cell first');return false;}
if(_f.cur_grid_cell.grid!=this){show_alert('Select a cell first');return false;}
return true;}
-_f.FormGrid.prototype.delete_row=function(dt,dn){if(dt&&dn){LocalDB.delete_record(dt,dn);this.refresh();}else{if(!this.check_selected())return;var r=_f.cur_grid_cell.row;if(r.is_newrow)return;var ci=_f.cur_grid_cell.cellIndex;var ri=_f.cur_grid_cell.row.rowIndex;LocalDB.delete_record(this.doctype,r.docname);this.refresh();if(ri<(this.tab.rows.length-2))
+_f.FormGrid.prototype.delete_row=function(dt,dn){if(dt&&dn){LocalDB.delete_record(dt,dn);this.refresh();}else{if(!this.check_selected())return;var r=_f.cur_grid_cell.row;if(r.is_newrow)return;var ci=_f.cur_grid_cell.cellIndex;var ri=_f.cur_grid_cell.row.rowIndex;LocalDB.delete_record(this.doctype,r.docname);this.refresh();if(ri<(this.tab.rows.length-1))
this.cell_select(null,ri,ci);else _f.cur_grid_cell=null;}
this.set_unsaved();}
_f.FormGrid.prototype.move_row=function(up){if(!this.check_selected())return;var r=_f.cur_grid_cell.row;if(r.is_newrow)return;if(up&&r.rowIndex>0){var swap_row=this.tab.rows[r.rowIndex-1];}else if(!up){var len=this.tab.rows.length;if(this.tab.rows[len-1].is_newrow)
@@ -2134,10 +2136,10 @@
set_field_permlevel=function(n,level){var df=get_field(cur_frm.doctype,n,cur_frm.docname);if(df)df.permlevel=level;refresh_field(n);}
hide_field=function(n){function _hide_field(n,hidden){var df=get_field(cur_frm.doctype,n,cur_frm.docname);if(df){df.hidden=hidden;refresh_field(n);}
else{console.log("hide_field cannot find field "+n);}}
-if(cur_frm){if(n.substr)_hide_field(n,1);else{for(var i in n)_hide_field(n[i],1)}}}
+if(cur_frm){if(typeof n=='string')_hide_field(n,1);else{for(var i in n)_hide_field(n[i],1)}}}
unhide_field=function(n){function _hide_field(n,hidden){var df=get_field(cur_frm.doctype,n,cur_frm.docname);if(df){df.hidden=hidden;refresh_field(n);}
else{console.log("unhide_field cannot find field "+n);}}
-if(cur_frm){if(n.substr)_hide_field(n,0);else{for(var i in n)_hide_field(n[i],0)}}}
+if(cur_frm){if(typeof n=='string')_hide_field(n,0);else{for(var i in n)_hide_field(n[i],0)}}}
get_field_obj=function(fn){return cur_frm.fields_dict[fn];}
/*
* lib/js/legacy/widgets/form/form_comments.js