Employee Benefit Application - refactor validation
diff --git a/erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py b/erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py
index 56b711b..05725d6 100644
--- a/erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py
+++ b/erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py
@@ -12,13 +12,11 @@
class EmployeeBenefitApplication(Document):
def validate(self):
+ self.validate_duplicate_on_payroll_period()
if self.max_benefits <= 0:
frappe.throw(_("Employee {0} has no maximum benefit amount").format(self.employee))
self.validate_max_benefit_for_component()
- def before_submit(self):
- self.validate_duplicate_on_payroll_period()
-
def validate_max_benefit_for_component(self):
if self.employee_benefits:
max_benefit_amount = 0