fix(pr): set adv. pay. status for po (still fails; differently)
diff --git a/erpnext/accounts/doctype/payment_request/payment_request.py b/erpnext/accounts/doctype/payment_request/payment_request.py
index 196838a..48f7e70 100644
--- a/erpnext/accounts/doctype/payment_request/payment_request.py
+++ b/erpnext/accounts/doctype/payment_request/payment_request.py
@@ -152,32 +152,32 @@
def on_submit(self):
if self.payment_request_type == "Outward":
self.db_set("status", "Initiated")
- return
elif self.payment_request_type == "Inward":
self.db_set("status", "Requested")
- send_mail = self.payment_gateway_validation() if self.payment_gateway else None
- ref_doc = frappe.get_doc(self.reference_doctype, self.reference_name)
+ if self.payment_request_type == "Inward":
+ send_mail = self.payment_gateway_validation() if self.payment_gateway else None
+ ref_doc = frappe.get_doc(self.reference_doctype, self.reference_name)
- if (
- hasattr(ref_doc, "order_type") and ref_doc.order_type == "Shopping Cart"
- ) or self.flags.mute_email:
- send_mail = False
+ if (
+ hasattr(ref_doc, "order_type") and ref_doc.order_type == "Shopping Cart"
+ ) or self.flags.mute_email:
+ send_mail = False
- if send_mail and self.payment_channel != "Phone":
- self.set_payment_request_url()
- self.send_email()
- self.make_communication_entry()
+ if send_mail and self.payment_channel != "Phone":
+ self.set_payment_request_url()
+ self.send_email()
+ self.make_communication_entry()
- elif self.payment_channel == "Phone":
- self.request_phone_payment()
+ elif self.payment_channel == "Phone":
+ self.request_phone_payment()
- advance_payment_doctypes = frappe.get_hooks("advance_payment_receivable_doctypes") + frappe.get_hooks(
- "advance_payment_payable_doctypes"
- )
- if self.reference_doctype in advance_payment_doctypes:
- # set advance payment status
- ref_doc.set_total_advance_paid()
+ advance_payment_doctypes = frappe.get_hooks("advance_payment_receivable_doctypes") + frappe.get_hooks(
+ "advance_payment_payable_doctypes"
+ )
+ if self.reference_doctype in advance_payment_doctypes:
+ # set advance payment status
+ ref_doc.set_total_advance_paid()
def request_phone_payment(self):
controller = _get_payment_gateway_controller(self.payment_gateway)