commit cb3754a1020f67b23228a1e12599ebd399b0211d
author Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Tue Feb 01 12:18:47 2022 +0530
committer GitHub <noreply@github.com> Tue Feb 01 12:18:47 2022 +0530
tree d07b835e97163d19a3769a0e0d8bad9dc91f3248
parent 62e5aa7d725e0a49c588128fb2eac4c9a3cdaa70
parent fa2b3eb41431cfc228a521b369b07ddd89bcc644

Merge pull request #29535 from ruchamahabal/fix-loan-repayment

fix: do not hide Loan Repayment Entry field in salary slip

erpnext/controllers/selling_controller.py

diff --git a/erpnext/controllers/selling_controller.py b/erpnext/controllers/selling_controller.py
index 4ff851d..75fcaee 100644
--- a/erpnext/controllers/selling_controller.py
+++ b/erpnext/controllers/selling_controller.py
@@ -204,7 +204,7 @@
 		valuation_rate_map = {}
 
 		for item in self.items:
-			if not item.item_code:
+			if not item.item_code or item.is_free_item:
 				continue
 
 			last_purchase_rate, is_stock_item = frappe.get_cached_value(
@@ -251,7 +251,7 @@
 			valuation_rate_map[(rate.item_code, rate.warehouse)] = rate.valuation_rate
 
 		for item in self.items:
-			if not item.item_code:
+			if not item.item_code or item.is_free_item:
 				continue
 
 			last_valuation_rate = valuation_rate_map.get(