fix(HR): validations and bug fixes for Attendance Log
diff --git a/erpnext/config/hr.py b/erpnext/config/hr.py
index 0f009b8..a91e078 100644
--- a/erpnext/config/hr.py
+++ b/erpnext/config/hr.py
@@ -35,6 +35,13 @@
"hide_count": True,
"dependencies": ["Employee"]
},
+ {
+ "type": "doctype",
+ "name": "Employee Attendance Log",
+ "hide_count": True,
+ "onboard": 1,
+ "dependencies": ["Employee"]
+ },
]
},
{
diff --git a/erpnext/hr/doctype/employee_attendance_log/employee_attendance_log.py b/erpnext/hr/doctype/employee_attendance_log/employee_attendance_log.py
index 6603b1c..956d9c3 100644
--- a/erpnext/hr/doctype/employee_attendance_log/employee_attendance_log.py
+++ b/erpnext/hr/doctype/employee_attendance_log/employee_attendance_log.py
@@ -9,7 +9,9 @@
from frappe import _
class EmployeeAttendanceLog(Document):
- pass
+ def validate(self):
+ if frappe.db.exists('Employee Attendance Log', {'employee': self.employee, 'time': self.time}):
+ frappe.throw('This log already exists for this employee.')
@frappe.whitelist()
@@ -37,6 +39,7 @@
doc.time = timestamp
doc.device_id = device_id
doc.log_type = log_type
- doc.save()
-
+ doc.insert()
+ frappe.db.commit()
+
return doc