| commit | d05412f96a02352d1203758a52fb80a8327df45c | [log] [tgz] |
|---|---|---|
| author | Rohit Waghchaure <rohitw1991@gmail.com> | Fri Mar 29 10:27:44 2024 +0530 |
| committer | Rohit Waghchaure <rohitw1991@gmail.com> | Fri Mar 29 10:53:04 2024 +0530 |
| tree | fd61a8d88964a13dbc418547b32706bdbda97bfc | |
| parent | ce2b9de9be30123d80f77d25994586386f226483 [diff] |
chore: show item name in the validation message
diff --git a/erpnext/public/js/utils/serial_no_batch_selector.js b/erpnext/public/js/utils/serial_no_batch_selector.js index 42d37bf4..1edeca9 100644 --- a/erpnext/public/js/utils/serial_no_batch_selector.js +++ b/erpnext/public/js/utils/serial_no_batch_selector.js
@@ -421,7 +421,7 @@ let { qty, based_on } = this.dialog.get_values(); if (this.item.serial_and_batch_bundle || this.item.rejected_serial_and_batch_bundle) { - if (qty === this.qty) { + if (this.qty && qty === Math.abs(this.qty)) { return; } }
diff --git a/erpnext/stock/doctype/serial_and_batch_bundle/serial_and_batch_bundle.py b/erpnext/stock/doctype/serial_and_batch_bundle/serial_and_batch_bundle.py index 7503531..19aad3f 100644 --- a/erpnext/stock/doctype/serial_and_batch_bundle/serial_and_batch_bundle.py +++ b/erpnext/stock/doctype/serial_and_batch_bundle/serial_and_batch_bundle.py
@@ -268,7 +268,8 @@ def validate_negative_batch(self, batch_no, available_qty): if available_qty < 0: - msg = f"""Batch No {bold(batch_no)} has negative stock + msg = f"""Batch No {bold(batch_no)} of an Item {bold(self.item_code)} + has negative stock of quantity {bold(available_qty)} in the warehouse {self.warehouse}"""