commit da5d5c4941f860b8152e40f1ab605838225eff22
author Parth J. Kharwar <parthjk98@gmail.com> Mon Dec 23 18:41:17 2019 +0530
committer Nabin Hait <nabinhait@gmail.com> Mon Dec 23 18:41:17 2019 +0530
tree 1ff2f7928dda673733fbca964a1727e22f27750a
parent d8c10bcedbb3f2ce71f98ee9eca24fbffd802fc2

fix(hr): update leave application status on cancel (#19883)

erpnext/hr/doctype/leave_application/leave_application.py

diff --git a/erpnext/hr/doctype/leave_application/leave_application.py b/erpnext/hr/doctype/leave_application/leave_application.py
index 915cea1..5222712 100755
--- a/erpnext/hr/doctype/leave_application/leave_application.py
+++ b/erpnext/hr/doctype/leave_application/leave_application.py
@@ -54,9 +54,11 @@
 		self.create_leave_ledger_entry()
 		self.reload()
 
+	def before_cancel(self):
+		self.status = "Cancelled"
+
 	def on_cancel(self):
 		self.create_leave_ledger_entry(submit=False)
-		self.status = "Cancelled"
 		# notify leave applier about cancellation
 		self.notify_employee()
 		self.cancel_attendance()