commit dc2cd35b933ee038940578325efbec7c2f522906
author Deepesh Garg <deepeshgarg6@gmail.com> Sun Jul 25 21:26:22 2021 +0530
committer Deepesh Garg <deepeshgarg6@gmail.com> Mon Jul 26 19:07:02 2021 +0530
tree ca137fb6350c814d5564d0fbf508a7331d868282
parent 5749e52bf6f4a67d4ee899b07edc2c2ac8434bf6

fix: Convert null values to empty string on grouping

erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.py

diff --git a/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.py b/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.py
index c8d5737..f2b0a8c 100644
--- a/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.py
+++ b/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.py
@@ -104,7 +104,7 @@
 				where account in (%s)
 				and posting_date <= %s
 				and is_cancelled = 0
-				group by account, party_type, party
+				group by account, NULLIF(party_type,''), NULLIF(party,'')
 				having sum(debit) != sum(credit)
 				order by account
 			""" % (', '.join(['%s']*len(accounts)), '%s'), tuple(accounts + [self.posting_date]), as_dict=1)