chore: clean up
diff --git a/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.js b/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.js
index f29183a..58a2b8c 100644
--- a/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.js
+++ b/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.js
@@ -4,46 +4,44 @@
frappe.ui.form.on('Currency Exchange Settings', {
service_provider: function(frm) {
if (frm.doc.service_provider == "Exchangerate.host"){
- frm.doc.api_endpoint = "https://api.exchangerate.host/convert";
- frm.clear_table("req_params")
- frm.clear_table("result_key")
+ let result = ['result']
let params = {
date: '{transaction_date}',
from: '{from_currency}',
to: '{to_currency}'
}
- var row;
- $.each(params, function(key, value){
- row = frm.add_child("req_params");
- row.key = key;
- row.value = value;
- })
- row = frm.add_child("result_key");
- row.key = 'result';
- frm.refresh_fields();
- frm.save();
+ add_param(frm, "https://api.exchangerate.host/convert", params, result)
}
else if (frm.doc.service_provider == "Frankfurter.app"){
- frm.doc.api_endpoint = "https://frankfurter.app/{transaction_date}";
- frm.clear_table("req_params")
- frm.clear_table("result_key")
- var row;
let result = ['rates', '{to_currency}']
let params = {
base: '{from_currency}',
symbols: '{to_currency}'
}
- $.each(params, function(key, value){
- row = frm.add_child("req_params");
- row.key = key;
- row.value = value;
- })
- $.each(result, function(key, value){
- row = frm.add_child("result_key");
- row.key = value;
- })
- frm.refresh_fields();
- frm.save();
+ add_param(frm, "https://frankfurter.app/{transaction_date}", params, result)
}
}
});
+
+
+function add_param(frm, api, params, result){
+ var row;
+ frm.clear_table("req_params")
+ frm.clear_table("result_key")
+
+ frm.doc.api_endpoint = api;
+
+ $.each(params, function(key, value){
+ row = frm.add_child("req_params");
+ row.key = key;
+ row.value = value;
+ });
+
+ $.each(result, function(key, value){
+ row = frm.add_child("result_key");
+ row.key = value;
+ });
+
+ frm.refresh_fields();
+ frm.save();
+}