commit e7e2e93419caf714941ed3a87495fcba76cef365
author Nabin Hait <nabinhait@gmail.com> Mon Apr 15 10:08:28 2019 +0530
committer GitHub <noreply@github.com> Mon Apr 15 10:08:28 2019 +0530
tree 7436c632ca755165da54fbdd25490d8b14416006
parent 8ab393448fb4fbbbbca265e914597f7f04ba1859
parent 4da3d0015a1483c350bf6384d2ce4b63a80775f2

Merge pull request #17183 from netchampfaris/duplicate-variant-check-d

fix: Validate variant attributes only if is_new

erpnext/stock/doctype/item/item.py

diff --git a/erpnext/stock/doctype/item/item.py b/erpnext/stock/doctype/item/item.py
index c07dc15..aa51f47 100644
--- a/erpnext/stock/doctype/item/item.py
+++ b/erpnext/stock/doctype/item/item.py
@@ -801,7 +801,7 @@
 					attributes.append(d.attribute)
 
 	def validate_variant_attributes(self):
-		if self.variant_of and self.variant_based_on == 'Item Attribute':
+		if self.is_new() and self.variant_of and self.variant_based_on == 'Item Attribute':
 			args = {}
 			for d in self.attributes:
 				if cstr(d.attribute_value).strip() == '':