perf: commit GL reposting periodically
If you have a huge list of docs to repost then maintaining transaction
throughtout entire GL reposting is not only unnecessary but also creates
performance issues. Periodically commiting the changes prevents lost
progress and reduces memory usage.
diff --git a/erpnext/accounts/utils.py b/erpnext/accounts/utils.py
index df5e37d..8711395 100644
--- a/erpnext/accounts/utils.py
+++ b/erpnext/accounts/utils.py
@@ -1145,7 +1145,7 @@
precision = get_field_precision(frappe.get_meta("GL Entry").get_field("debit")) or 2
gle = get_voucherwise_gl_entries(stock_vouchers, posting_date)
- for voucher_type, voucher_no in stock_vouchers:
+ for idx, (voucher_type, voucher_no) in enumerate(stock_vouchers):
existing_gle = gle.get((voucher_type, voucher_no), [])
voucher_obj = frappe.get_doc(voucher_type, voucher_no)
# Some transactions post credit as negative debit, this is handled while posting GLE
@@ -1160,6 +1160,11 @@
else:
_delete_gl_entries(voucher_type, voucher_no)
+ if idx % 20 == 0:
+ # Commit every 20 documents to avoid losing progress
+ # and reducing memory usage
+ frappe.db.commit()
+
def sort_stock_vouchers_by_posting_date(
stock_vouchers: List[Tuple[str, str]]