commit f574121741800425e9eb8b34a78e26d8ed1d877a
author Ankush Menat <ankush@frappe.io> Mon Apr 25 15:05:10 2022 +0530
committer Ankush Menat <ankush@frappe.io> Wed Apr 27 12:05:15 2022 +0530
tree 50a972b995ae45c14adcc000584723853975e8d9
parent 277b51b40482447639d2c0b9d5440e758ea0b76f

refactor: simpler check for non-SO items

erpnext/stock/doctype/pick_list/pick_list.py

diff --git a/erpnext/stock/doctype/pick_list/pick_list.py b/erpnext/stock/doctype/pick_list/pick_list.py
index a947456..9daf4f1 100644
--- a/erpnext/stock/doctype/pick_list/pick_list.py
+++ b/erpnext/stock/doctype/pick_list/pick_list.py
@@ -517,13 +517,7 @@
 	if sales_dict:
 		delivery_note = create_dn_with_so(sales_dict, pick_list)
 
-	is_item_wo_so = 0
-	for location in pick_list.locations:
-		if not location.sales_order:
-			is_item_wo_so = 1
-			break
-	if is_item_wo_so == 1:
-		# Create a DN for items without sales orders as well
+	if not all(item.sales_order for item in pick_list.locations):
 		delivery_note = create_dn_wo_so(pick_list)
 
 	frappe.msgprint(_("Delivery Note(s) created for the Pick List"))